Home GnuPG

gnome3: Drop unnecessary use of gtk
65d8e0ec1979Unpublished

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

gnome3: Drop unnecessary use of gtk

* configure.ac: pinentry-gnome3 only needs gcr-base, not gcr.
* gnome3/pinentry-gnome3.c (main): Instead of testing whether GTK can
be loaded, check for DBUS_SESSION_BUS_ADDRESS.
(create_prompt): Use fprintf (stderr, ...) instead of g_warning (...),
to align with the rest of pinentry.c.

pinentry-gnome3 really just uses gcr and libsecret -- there is no
direct use of gtk at all. By linking only to the minimal gcr-base-3
and avoiding gcr-3 itself, we remove many unnecessary library
dependencies from pinentry-gnome3.

Specifically, "ldd $(which pinentry-gnome3) | wc -l" goes from 69 to
23 on debian testing.

Added missing LF.

  • Signed-off-by: Werner Koch <wk@gnupg.org>

Details

Provenance
wernerAuthored on Oct 4 2016, 10:35 AM
Parents
rP777650b9b021: core: Add a way to print ERROR status lines.
Branches
Unknown
Tags
Unknown