Home GnuPG

Allow users to "Force accept" package reviews if they own a more general package
2fbc9a52da9bUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Allow users to "Force accept" package reviews if they own a more general package

Summary:
Ref T12272. If you own a package which owns "/", this allows you to force-accept package reviews for packages which own sub-paths, like "/src/adventure/".

The default UI looks something like this:

[X] Accept as epriestley
[X] Accept as Root Package
[ ] Force accept as Adventure Package

By default, force-accepts are not selected.

(I may do some UI cleanup and/or annotate "because you own X" in the future and/or mark these accepts specially in some way, particularly if this proves confusing along whatever dimension.)

Test Plan: {F4314747}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12272

Differential Revision: https://secure.phabricator.com/D17569

Details

Provenance
epriestley <git@epriestley.com>Authored on Mar 28 2017, 6:30 PM
Parents
rPHABddc02ce420a5: When voiding "Accept" reviews, also void "Reject" reviews
Branches
Unknown
Tags
Unknown

Event Timeline