Home GnuPG

Ignore "Auditors: author" when inferring auditors from commit messages
65de9e9f5e7fUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Ignore "Auditors: author" when inferring auditors from commit messages

Summary:
Fixes T12406. When importing commits, we automatically add auditors if the message lists "Auditors: username".

If the list of auditors includes the commit author, this edit fails because you can't audit your own commits (previously, you sometimes could and/or we didn't validate).

Instead, just ignore "Auditors: author".

Test Plan:

  • Made a commit with "Auditors: epriestley".
  • Pushed it.
  • Saw the HeraldWorker get stuck with the error in T12406.
  • Applied the change; worker now succeeded.

Reviewers: chad

Reviewed By: chad

Subscribers: alexmv

Maniphest Tasks: T12406

Differential Revision: https://secure.phabricator.com/D17507

Details

Provenance
epriestley <git@epriestley.com>Authored on Mar 16 2017, 8:22 PM
Parents
rPHABba2ee3a66e89: Make "bin/config set --database ..." resurrect deleted values
Branches
Unknown
Tags
Unknown

Event Timeline