Home GnuPG

Make "bin/config set --database ..." resurrect deleted values
ba2ee3a66e89Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Make "bin/config set --database ..." resurrect deleted values

Summary:
Fixes T12409. Config entries may be marked as "deleted", and bin/config set --database doesn't un-delete them, so the edit doesn't do anything.

The "most correct" fix here is to swap to transactions so we run the same code, but just fix this narrowly for now since it's one line of code.

Test Plan:

  • Set maniphest.default-priority to 123.
  • Deleted maniphest.default-priority from the web UI by deleting all the text in the box.
  • Before patch: bin/config set --database maniphest.default-priority 789 had no effect.
  • After patch: bin/config set --database maniphest.default-priority 789 worked.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12409

Differential Revision: https://secure.phabricator.com/D17506

Details

Provenance
epriestley <git@epriestley.com>Authored on Mar 16 2017, 7:55 PM
Parents
rPHABde4e8728b2fa: Add ActionIcon to PHUIListItemView, use in Dashboards
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHABba2ee3a66e89: Make "bin/config set --database ..." resurrect deleted values (authored by epriestley <git@epriestley.com>).Mar 16 2017, 8:26 PM