Home GnuPG

Move many "reviewers" readers to new storage
dccd799b1b44Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Move many "reviewers" readers to new storage

Summary:
Ref T10967.

When we query for revisions with particular reviewers, use the new table to drive the query.

When we load revisions for use in the application, also use the new table to drive the query.

This doesn't convert everything: there's some old loadRelationships() stuff still using the old table. But this moves the major stuff over.

(This also changes the icon for "commented" from a question mark to a speech bubble.)

Test Plan:

  • Viewed revision lists and detail views on old and new code, saw identical outcomes.
  • Updated revisions, accepted/rejected/commented on revisions.
  • Hit the "Accepted Older" and "Commented Older" states by taking an action and then updating.
  • Grepped for removed methods (like getEdgeData() and getDiffID()).

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10967

Differential Revision: https://secure.phabricator.com/D17517

Details

Provenance
epriestley <git@epriestley.com>Authored on Mar 20 2017, 8:35 PM
Parents
rPHAB8ad5d28686a4: Migrate old reviewer edges to new storage
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHABdccd799b1b44: Move many "reviewers" readers to new storage (authored by epriestley <git@epriestley.com>).Mar 21 2017, 12:45 AM