Home GnuPG

If the overseer can't update the PID file, just move on
fa993854745cUnpublished

Unpublished Commit ยท Learn More

Publishing Disabled: All publishing is disabled for this repository.

Description

If the overseer can't update the PID file, just move on

Summary:
Ref T12857. This is a little murky, but this behavior seems clearly better.

When the disk is full, daemons may attempt to update their PID files and fail. When this happens, keep running rather than exiting.

Test Plan:

  • Made Filesystem::writeFile() throw an exception unconditionally to simulate a full disk.
  • Ran bin/phd start.
  • Saw daemons exit immediately.
  • Applied patch, saw daemons stick around and do useful work instead.

Reviewers: chad, amckinley

Reviewed By: chad

Maniphest Tasks: T12857

Differential Revision: https://secure.phabricator.com/D18139

Details

Provenance
epriestley <git@epriestley.com>Authored on Jun 19 2017, 11:51 PM
marcusPushed on Jun 27 2017, 9:06 PM
Parents
rPHUTIL0237d446882c: Make empty Remarkup table rows have more intuitive behavior
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHUTILfa993854745c: If the overseer can't update the PID file, just move on (authored by epriestley <git@epriestley.com>).Jun 20 2017, 2:44 PM