secmem fix
AbandonedPublic
Actions

Authored by • gniibe on Jun 1 2017, 2:13 PM.

Details

Reviewers

Summary

secmem implementation has two bugs:
(1) Under some heavy use, it gets SEGV.
(2) Calculation of allocated memory is wrong.

I think this patch fixes these two problems.

Test Plan

Repository

rC libgcrypt

Lint

Lint Skipped

Unit

Unit Tests Skipped

Here is a test case:

secmem-test.c1003 BDownload

It doesn't dump core on my x86 GNU/Linux, but we can see invalid stats.
Running under valgrind, it dumps core.

Path

Size

src/

10 lines