Page MenuHome GnuPG
Differential D431

secmem fix
AbandonedPublic
Actions

Authored by gniibe on Jun 1 2017, 2:13 PM.

Details

Reviewers
werner
Summary

secmem implementation has two bugs:
(1) Under some heavy use, it gets SEGV.
(2) Calculation of allocated memory is wrong.

I think this patch fixes these two problems.

Test Plan

T3027: gpg-agent crash on macOS Sierra triggerd by ssh

Diff Detail

Repository
rC libgcrypt
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

gniibe created this revision.Jun 1 2017, 2:13 PM
gniibe mentioned this in T3027: gpg-agent crash on macOS Sierra triggerd by ssh.Jun 1 2017, 2:16 PM
gniibe added a comment.Jun 2 2017, 3:31 AM

Here is a test case:

secmem-test.c1003 BDownload

It doesn't dump core on my x86 GNU/Linux, but we can see invalid stats.
Running under valgrind, it dumps core.

gniibe added a comment.Jun 2 2017, 3:40 AM

Applied in rCe0958debe1a7: secmem: Fix SEGV and stat calculation..

gniibe abandoned this revision.Jun 8 2017, 6:39 AM

Revision Contents
Changeset List

PathSize
src/
10 lines

Diff 1275

View Options

src/secmem.c

Loading...