Change SOCK_CTX (internal one) system hooks
ClosedPublic
Actions

Authored by • werner on Dec 6 2017, 10:22 AM.

Details

Reviewers

• aheinecke
• gniibe

Summary

Thread initialization is better to be deferred after fork (in case of UNIX).
assuan_sock_init should be earlier.
Thus, we need to change system hooks for assuan_sock_* interface.
Or else, on Windows, it may cause hang on server.

Test Plan

test on Windows.

Diff Detail

Repository

rG GnuPG

Lint

Lint Skipped

Unit

Unit Tests Skipped

Event Timeline

• gniibe created this revision.Dec 6 2017, 10:22 AM

• gniibe mentioned this in T3378: gpg-agent.exe hanging after left to idle for a while.

Tested it on Windows, with the sleep test patch in Libassuan it does not hang anymore when it hanged without this change.

This revision is now accepted and ready to land.Dec 6 2017, 10:36 AM

• werner commandeered this revision.Dec 7 2017, 6:25 PM

• werner closed this revision.

• werner edited reviewers, added: • gniibe; removed: • werner.

Revision Contents
Changeset List

Path

Size

agent/

gpg-agent.c

3 lines

Diff 1327

View Options

Change SOCK_CTX (internal one) system hooksClosedPublicActions