Paths

Table of Contentst

Differential D487

gpg: don't delete any keys if --dry-run is passed
AbandonedPublic
Actions

Authored by matheusmoreira on May 8 2019, 11:48 PM.

Tags

None

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested)
Commits: rKLEOPATRA5e9d402be380: Yet another place with deprecated API
rG110a4550179f: gpg: Do not delete any keys if --dry-run is passed.

Summary

g10/delkey.c (do_delete_key): Don't delete the key block on dry runs.

(do_delete_key): Don't clear ownertrusts on dry runs.
(gpg_agent_delete_secret_key): Don't contact the agent on dry runs.

Signed-off-by: Matheus Afonso Martins Moreira <matheus.a.m.moreira@gmail.com>

Test Plan

All key deletion commands should do nothing if the --dry-run is given.

Diff Detail

Repository

Lint

Lint Skipped

Unit

Unit Tests Skipped

Event Timeline

matheusmoreira created this revision.May 8 2019, 11:48 PM

matheusmoreira added a parent revision: D485: gpg: add the --delete-secret-subkeys command.

matheusmoreira added a child revision: D488: gpg: add the --delete-secret-key-stubs command.May 8 2019, 11:53 PM

matheusmoreira added a task: T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).May 8 2019, 11:59 PM

matheusmoreira added a commit: rG110a4550179f: gpg: Do not delete any keys if --dry-run is passed..May 21 2019, 11:03 PM

Committed to master: 110a4550179f

matheusmoreira removed a parent revision: D485: gpg: add the --delete-secret-subkeys command.May 22 2019, 2:38 AM

matheusmoreira removed a child revision: D488: gpg: add the --delete-secret-key-stubs command.

• Fred23 added a commit: rKLEOPATRA5e9d402be380: Yet another place with deprecated API.Jun 20 2021, 6:09 PM

Revision Contents
Changeset List

Path

Size

g10/

14 lines

Diff 1373

g10/delkey.c

Loading...