Page MenuHome GnuPG

matheusmoreira (Matheus Afonso Martins Moreira)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Apr 13 2019, 6:37 AM (131 w, 3 d)
Availability
Available

Recent Activity

Jun 6 2019

matheusmoreira renamed T4544: More prompts before key deletion from Key deletion: more prompts, new commands to More prompts before key deletion.
Jun 6 2019, 5:39 AM · gnupg, Feature Request, patch
matheusmoreira added a comment to T4170: Backing up, transporting, and transferring private keys from device to device.
  • --import-options restore
    • Implies
      • import-local-sigs
      • keep-ownertrust
    • Turns off
      • import-minimal
      • import-clean
      • repair-pks-subkey-bug
      • merge-only
Jun 6 2019, 5:14 AM · nGPH
matheusmoreira added a comment to T4170: Backing up, transporting, and transferring private keys from device to device.
  • --export-options backup
    • Implies
      • export-local-sigs
      • export-attributes
      • export-sensitive-revkeys
    • Turns off
      • export-clean
      • export-minimal
      • export-pka
      • export-dane
    • Causes build_packet_and_meta() to be used instead of build_packet()
      • This variant also writes the meta data using ring trust packets.
        • a8895c99a7d0
          • Ring trust packets are implementation defined and have always been used in gpg to cache the signature verification status.
          • Ring trust packets are only exported with the export option "backup" and only imported with the import option "restore".
          • As a side-effect of this patch the signature status cache works again and "gpg --check-sigs" is thus much faster.
        • RFC 4880 § 5.10
        • doc/DETAILS
Jun 6 2019, 5:06 AM · nGPH
matheusmoreira reopened T4544: More prompts before key deletion as "Open".

Here are the patches without any new commands:

Jun 6 2019, 3:58 AM · gnupg, Feature Request, patch
matheusmoreira abandoned D485: gpg: add the --delete-secret-subkeys command.

New commands can't be introduced.

Jun 6 2019, 3:24 AM
matheusmoreira abandoned D488: gpg: add the --delete-secret-key-stubs command.

New commands can't be introduced.

Jun 6 2019, 3:23 AM
matheusmoreira added a comment to T4544: More prompts before key deletion.

@werner Only patches 2 and 3 introduce new commands. What do you think about the other changes?

Jun 6 2019, 3:20 AM · gnupg, Feature Request, patch

Jun 5 2019

matheusmoreira changed Version from 2.2.15 to 2.2.16 on T4544: More prompts before key deletion.
Jun 5 2019, 11:53 AM · gnupg, Feature Request, patch

May 29 2019

matheusmoreira added a comment to T3465: --pinentry-mode loopback with --delete-secret-keys.

I also experienced this issue while testing my --delete-secret-key patches. Passing --pinentry-program /usr/bin/pinentry-tty to the gpg-agent worked around it.

May 29 2019, 10:16 AM · gnupg, Bug Report
matheusmoreira updated the task description for T4544: More prompts before key deletion.
May 29 2019, 10:10 AM · gnupg, Feature Request, patch
matheusmoreira updated the summary of D485: gpg: add the --delete-secret-subkeys command.
May 29 2019, 10:09 AM
matheusmoreira updated the diff for D481: gpg: confirm deletion of each key individually.

Add confirmation prompt for exactly-specified public subkeys.

May 29 2019, 10:06 AM
matheusmoreira updated the diff for D488: gpg: add the --delete-secret-key-stubs command.

Add documentation.

May 29 2019, 10:05 AM
matheusmoreira updated the diff for D485: gpg: add the --delete-secret-subkeys command.

Add documentation.

May 29 2019, 10:03 AM
matheusmoreira updated the task description for T4544: More prompts before key deletion.
May 29 2019, 10:00 AM · gnupg, Feature Request, patch

May 28 2019

matheusmoreira updated the diff for D482: gpg: confirm again before deleting primary key.
May 28 2019, 5:55 PM
matheusmoreira updated the diff for D481: gpg: confirm deletion of each key individually.
May 28 2019, 5:53 PM
matheusmoreira updated the diff for D488: gpg: add the --delete-secret-key-stubs command.
May 28 2019, 5:52 PM
matheusmoreira updated the diff for D485: gpg: add the --delete-secret-subkeys command.
May 28 2019, 5:50 PM
matheusmoreira updated the diff for D480: gpg: factor out secret key deletion function.

Remove gpg_ prefix from function.

May 28 2019, 5:46 PM
matheusmoreira abandoned D483: po: add portuguese primary key deletion message.

Squashed: D482

May 28 2019, 5:43 PM
matheusmoreira abandoned D486: po: add portuguese description for new command.

Squashed: D485

May 28 2019, 5:43 PM
matheusmoreira abandoned D489: po: add portuguese translation for the new command.

Squashed: D488

May 28 2019, 5:41 PM
matheusmoreira added a task to D488: gpg: add the --delete-secret-key-stubs command: T4544: More prompts before key deletion.
May 28 2019, 5:39 PM
matheusmoreira added a task to D480: gpg: factor out secret key deletion function: T4544: More prompts before key deletion.
May 28 2019, 5:39 PM
matheusmoreira added a task to D485: gpg: add the --delete-secret-subkeys command: T4544: More prompts before key deletion.
May 28 2019, 5:39 PM
matheusmoreira added revisions to T4544: More prompts before key deletion: D480: gpg: factor out secret key deletion function, D485: gpg: add the --delete-secret-subkeys command, D488: gpg: add the --delete-secret-key-stubs command, D481: gpg: confirm deletion of each key individually, D482: gpg: confirm again before deleting primary key.
May 28 2019, 5:39 PM · gnupg, Feature Request, patch
matheusmoreira added a task to D482: gpg: confirm again before deleting primary key: T4544: More prompts before key deletion.
May 28 2019, 5:39 PM
matheusmoreira added a task to D481: gpg: confirm deletion of each key individually: T4544: More prompts before key deletion.
May 28 2019, 5:39 PM
matheusmoreira abandoned D479: gpg: avoid deletion of keys not specified by user.

A better solution has been commited: cc6069ac6ecd

May 28 2019, 5:35 PM
matheusmoreira created T4544: More prompts before key deletion in the S1 Public space.
May 28 2019, 5:21 PM · gnupg, Feature Request, patch

May 27 2019

matheusmoreira added a comment to T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).

@werner Thank you for resolving this issue.

May 27 2019, 1:04 PM · patch, Bug Report, gnupg

May 22 2019

matheusmoreira updated the diff for D489: po: add portuguese translation for the new command.

Rebased on top of master: 4c7d63cd5b02

May 22 2019, 2:28 AM
matheusmoreira updated the diff for D488: gpg: add the --delete-secret-key-stubs command.

Rebased on top of master: 4c7d63cd5b02

May 22 2019, 2:27 AM
matheusmoreira updated the summary of D486: po: add portuguese description for new command.
May 22 2019, 2:26 AM
matheusmoreira updated the diff for D486: po: add portuguese description for new command.

Rebased on top of master: 4c7d63cd5b02

May 22 2019, 2:26 AM
matheusmoreira updated the diff for D485: gpg: add the --delete-secret-subkeys command.

Rebased on top of master: 4c7d63cd5b02

May 22 2019, 2:20 AM
matheusmoreira updated the diff for D483: po: add portuguese primary key deletion message.

Rebased on top of master: 4c7d63cd5b02

May 22 2019, 2:18 AM
matheusmoreira updated the diff for D482: gpg: confirm again before deleting primary key.

Rebased on top of master: 4c7d63cd5b02

May 22 2019, 2:17 AM
matheusmoreira updated the diff for D481: gpg: confirm deletion of each key individually.

Rebased on top of master: 4c7d63cd5b02
Add the if (okay) conditional back to the code

May 22 2019, 2:15 AM
matheusmoreira updated the diff for D480: gpg: factor out secret key deletion function.

Rebased on top of master: 4c7d63cd5b02

May 22 2019, 2:13 AM
matheusmoreira updated the diff for D479: gpg: avoid deletion of keys not specified by user.

Rebased on top of master: 4c7d63cd5b02

May 22 2019, 2:12 AM
matheusmoreira added a comment to T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).

@werner Thanks for merging the --dry-run patch in 110a4550179f !

May 22 2019, 2:10 AM · patch, Bug Report, gnupg

May 21 2019

matheusmoreira abandoned D487: gpg: don't delete any keys if --dry-run is passed.

Committed to master: 110a4550179f

May 21 2019, 11:09 PM

May 9 2019

matheusmoreira added a comment to T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).

It appears this issue was first identified and triaged in 2016: T2879
The subkey deletion feature also showed up in other issues since then:

May 9 2019, 9:14 PM · patch, Bug Report, gnupg

May 8 2019

matheusmoreira added revisions to T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested): D487: gpg: don't delete any keys if --dry-run is passed, D488: gpg: add the --delete-secret-key-stubs command, D489: po: add portuguese translation for the new command.
May 8 2019, 11:59 PM · patch, Bug Report, gnupg
matheusmoreira added a task to D489: po: add portuguese translation for the new command: T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).
May 8 2019, 11:59 PM
matheusmoreira added a task to D488: gpg: add the --delete-secret-key-stubs command: T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).
May 8 2019, 11:59 PM
matheusmoreira added a task to D487: gpg: don't delete any keys if --dry-run is passed: T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).
May 8 2019, 11:59 PM
matheusmoreira retitled D489: po: add portuguese translation for the new command from po: add portuguese translation for the new to po: add portuguese translation for the new command.
May 8 2019, 11:58 PM
matheusmoreira created D489: po: add portuguese translation for the new command.
May 8 2019, 11:56 PM
matheusmoreira created D488: gpg: add the --delete-secret-key-stubs command.
May 8 2019, 11:53 PM
matheusmoreira created D487: gpg: don't delete any keys if --dry-run is passed.
May 8 2019, 11:48 PM
matheusmoreira added a project to T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested): patch.
May 8 2019, 1:08 AM · patch, Bug Report, gnupg
matheusmoreira added a comment to T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).

Diffs downloaded from the revisions don't include commit messages for some reason. Here are all the commits I submitted for review as patch files with messages:

May 8 2019, 12:51 AM · patch, Bug Report, gnupg

May 4 2019

matheusmoreira added a task to D485: gpg: add the --delete-secret-subkeys command: T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).
May 4 2019, 10:23 PM
matheusmoreira added revisions to T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested): D485: gpg: add the --delete-secret-subkeys command, D486: po: add portuguese description for new command.
May 4 2019, 10:23 PM · patch, Bug Report, gnupg
matheusmoreira added a task to D486: po: add portuguese description for new command: T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).
May 4 2019, 10:23 PM
matheusmoreira created D486: po: add portuguese description for new command.
May 4 2019, 10:22 PM
matheusmoreira created D485: gpg: add the --delete-secret-subkeys command.
May 4 2019, 10:17 PM

May 3 2019

matheusmoreira added a task to D482: gpg: confirm again before deleting primary key: T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).
May 3 2019, 8:58 PM
matheusmoreira added a task to D480: gpg: factor out secret key deletion function: T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).
May 3 2019, 8:58 PM
matheusmoreira added a task to D483: po: add portuguese primary key deletion message: T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).
May 3 2019, 8:58 PM
matheusmoreira added revisions to T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested): D479: gpg: avoid deletion of keys not specified by user, D480: gpg: factor out secret key deletion function, D481: gpg: confirm deletion of each key individually, D482: gpg: confirm again before deleting primary key, D483: po: add portuguese primary key deletion message.
May 3 2019, 8:58 PM · patch, Bug Report, gnupg
matheusmoreira added a task to D481: gpg: confirm deletion of each key individually: T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).
May 3 2019, 8:58 PM
matheusmoreira added a task to D479: gpg: avoid deletion of keys not specified by user: T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).
May 3 2019, 8:58 PM

May 2 2019

matheusmoreira retitled D483: po: add portuguese primary key deletion message from po: add portuguese primary deletion message to po: add portuguese primary key deletion message.
May 2 2019, 5:23 AM
matheusmoreira added a comment to T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).

Revision D482 adds an extra confirmation prompt before deleting the secret primary key.
Revision D483 adds portuguese translation for the primary key deletion confirmation message.

May 2 2019, 5:22 AM · patch, Bug Report, gnupg
matheusmoreira created D483: po: add portuguese primary key deletion message.
May 2 2019, 5:16 AM
matheusmoreira created D482: gpg: confirm again before deleting primary key.
May 2 2019, 5:05 AM
matheusmoreira retitled D480: gpg: factor out secret key deletion function from gpg: factor out function that deletes secret keys to gpg: factor out secret key deletion function.
May 2 2019, 4:09 AM
matheusmoreira updated the test plan for D481: gpg: confirm deletion of each key individually.
May 2 2019, 4:04 AM
matheusmoreira updated the summary of D480: gpg: factor out secret key deletion function.
May 2 2019, 3:43 AM
matheusmoreira updated the test plan for D479: gpg: avoid deletion of keys not specified by user.
May 2 2019, 3:41 AM
matheusmoreira updated the diff for D480: gpg: factor out secret key deletion function.

Fix missing curly brace.

May 2 2019, 3:28 AM

Apr 30 2019

matheusmoreira created D481: gpg: confirm deletion of each key individually.
Apr 30 2019, 3:32 PM
matheusmoreira retitled D480: gpg: factor out secret key deletion function from gpg: factor out function that deletes secret keys to Factor out secret key deletion function.
Apr 30 2019, 3:20 PM
matheusmoreira created D480: gpg: factor out secret key deletion function.
Apr 30 2019, 3:17 PM
matheusmoreira updated the summary of D479: gpg: avoid deletion of keys not specified by user.
Apr 30 2019, 2:02 PM
matheusmoreira created D479: gpg: avoid deletion of keys not specified by user.
Apr 30 2019, 1:40 PM
matheusmoreira added a comment to T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).

@werner Here are the patches:

Apr 30 2019, 11:50 AM · patch, Bug Report, gnupg
matheusmoreira added a comment to T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).

I thought about building a list of keys targeted for deletion so gpg can then ask the user to confirm the deletion of each key individually.

Apr 30 2019, 11:35 AM · patch, Bug Report, gnupg

Apr 27 2019

matheusmoreira added a comment to T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).

@dkg, thanks for the feedback. I read [doc/HACKING](https://www.gnupg.org/faq/HACKING.html) and revised the commit message so that it contains ChangeLog entries and a marker line before my description. I compared my new message to prior log entries and they seem to match now. Is this appropriate? If so, I will revise my other commits in the same manner.

Apr 27 2019, 4:07 AM · patch, Bug Report, gnupg

Apr 26 2019

matheusmoreira added a comment to T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).

@dkg Sure! I thought I was supposed to email the patches to the development mailing list. [I've uploaded my delete-secret-subkey branch to GitHub.](https://github.com/matheusmoreira/gnupg/tree/delete-secret-subkey) You can see a comparison here. I'll describe my changes.

Apr 26 2019, 6:58 PM · patch, Bug Report, gnupg
matheusmoreira added a comment to T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).

I managed to make it work on my branch: gpg --delete-secret-key FPR! deletes just that key and no others! I will prepare a patch for this specific change and then try to implement the --delete-secret-subkeys command.

Apr 26 2019, 5:25 AM · patch, Bug Report, gnupg

Apr 16 2019

matheusmoreira added a comment to T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).

I've been studying the source code. When a fingerprint suffixed with ! is given as argument, the [do_delete_key](https://git.gnupg.org/cgi-bin/gitweb.cgi?p=gnupg.git;a=blob;f=g10/delkey.c;h=cc567384612ccf0dfd41d9e620d6cd5e759fd7b6;hb=HEAD#l50) function correctly classifies the search descriptor as exact and finds the correct key using [keydb_search](https://git.gnupg.org/cgi-bin/gitweb.cgi?p=gnupg.git;a=blob;f=g10/keydb.c;h=8c067e1dfbfa7a6394e44dbed3bfaef5a4fa7c43;hb=HEAD#l1853). However, the handle returned by [keydb_get_keyblock](https://git.gnupg.org/cgi-bin/gitweb.cgi?p=gnupg.git;a=blob;f=g10/keydb.c;h=8c067e1dfbfa7a6394e44dbed3bfaef5a4fa7c43;hb=HEAD#l1352) apparently includes the primary key and all subkeys associated with it. After confirming the action with the user, the function iterates over all PKT_PUBLIC_KEY and PKT_PUBLIC_SUBKEY packets present in the keyblock, obtains the keygrip of each key and asks gpg-agent to delete it.

Apr 16 2019, 7:29 AM · patch, Bug Report, gnupg