matheusmoreira (Matheus Afonso Martins Moreira)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Apr 13 2019, 6:37 AM (5 w, 6 d)
Availability
Available

Recent Activity

Wed, May 22

matheusmoreira added a dependent revision for D485: gpg: introduce the --delete-secret-subkeys command: D488: gpg: add the --delete-secret-key-stubs command.
Wed, May 22, 2:39 AM
matheusmoreira edited dependencies for D488: gpg: add the --delete-secret-key-stubs command, added: 1; removed: 1.
Wed, May 22, 2:39 AM
matheusmoreira removed a dependent revision for D487: gpg: don't delete any keys if --dry-run is passed: D488: gpg: add the --delete-secret-key-stubs command.
Wed, May 22, 2:39 AM
matheusmoreira removed a dependent revision for D485: gpg: introduce the --delete-secret-subkeys command: D487: gpg: don't delete any keys if --dry-run is passed.
Wed, May 22, 2:38 AM
matheusmoreira removed a dependency for D487: gpg: don't delete any keys if --dry-run is passed: D485: gpg: introduce the --delete-secret-subkeys command.
Wed, May 22, 2:38 AM
matheusmoreira updated the diff for D489: po: add portuguese translation for the new command.

Rebased on top of master: 4c7d63cd5b02

Wed, May 22, 2:28 AM
matheusmoreira updated the diff for D488: gpg: add the --delete-secret-key-stubs command.

Rebased on top of master: 4c7d63cd5b02

Wed, May 22, 2:27 AM
matheusmoreira updated the summary of D486: po: add portuguese description for new command.
Wed, May 22, 2:26 AM
matheusmoreira updated the diff for D486: po: add portuguese description for new command.

Rebased on top of master: 4c7d63cd5b02

Wed, May 22, 2:26 AM
matheusmoreira updated the diff for D485: gpg: introduce the --delete-secret-subkeys command.

Rebased on top of master: 4c7d63cd5b02

Wed, May 22, 2:20 AM
matheusmoreira updated the diff for D483: po: add portuguese primary key deletion message.

Rebased on top of master: 4c7d63cd5b02

Wed, May 22, 2:18 AM
matheusmoreira updated the diff for D482: gpg: confirm again before deleting primary key.

Rebased on top of master: 4c7d63cd5b02

Wed, May 22, 2:17 AM
matheusmoreira updated the diff for D481: gpg: confirm deletion of each secret key.

Rebased on top of master: 4c7d63cd5b02

Wed, May 22, 2:15 AM
matheusmoreira updated the diff for D480: gpg: factor out secret key deletion function.

Rebased on top of master: 4c7d63cd5b02

Wed, May 22, 2:13 AM
matheusmoreira updated the diff for D479: gpg: avoid deletion of keys not specified by user.

Rebased on top of master: 4c7d63cd5b02

Wed, May 22, 2:12 AM
matheusmoreira added a comment to T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).

@werner Thanks for merging the --dry-run patch in 110a4550179f !

Wed, May 22, 2:10 AM · patch, Bug Report, gnupg

Tue, May 21

matheusmoreira abandoned D487: gpg: don't delete any keys if --dry-run is passed.

Committed to master: 110a4550179f

Tue, May 21, 11:09 PM
matheusmoreira added an edge to rG110a4550179f: gpg: Do not delete any keys if --dry-run is passed.: D487: gpg: don't delete any keys if --dry-run is passed.
Tue, May 21, 11:03 PM
matheusmoreira added 1 commit(s) for D487: gpg: don't delete any keys if --dry-run is passed: rG110a4550179f: gpg: Do not delete any keys if --dry-run is passed..
Tue, May 21, 11:03 PM

Thu, May 9

matheusmoreira added a comment to T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).

It appears this issue was first identified and triaged in 2016: T2879
If merged, my patches should resolve that task as well.

Thu, May 9, 9:14 PM · patch, Bug Report, gnupg

Wed, May 8

matheusmoreira added revisions to T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested): D487: gpg: don't delete any keys if --dry-run is passed, D488: gpg: add the --delete-secret-key-stubs command, D489: po: add portuguese translation for the new command.
Wed, May 8, 11:59 PM · patch, Bug Report, gnupg
matheusmoreira added a task to D489: po: add portuguese translation for the new command: T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).
Wed, May 8, 11:59 PM
matheusmoreira added a task to D488: gpg: add the --delete-secret-key-stubs command: T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).
Wed, May 8, 11:59 PM
matheusmoreira added a task to D487: gpg: don't delete any keys if --dry-run is passed: T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).
Wed, May 8, 11:59 PM
matheusmoreira retitled D489: po: add portuguese translation for the new command from po: add portuguese translation for the new to po: add portuguese translation for the new command.
Wed, May 8, 11:58 PM
matheusmoreira added a dependent revision for D486: po: add portuguese description for new command: D489: po: add portuguese translation for the new command.
Wed, May 8, 11:57 PM
matheusmoreira added a dependency for D489: po: add portuguese translation for the new command: D486: po: add portuguese description for new command.
Wed, May 8, 11:57 PM
matheusmoreira added a dependent revision for D488: gpg: add the --delete-secret-key-stubs command: D489: po: add portuguese translation for the new command.
Wed, May 8, 11:56 PM
matheusmoreira added a dependency for D489: po: add portuguese translation for the new command: D488: gpg: add the --delete-secret-key-stubs command.
Wed, May 8, 11:56 PM
matheusmoreira created D489: po: add portuguese translation for the new command.
Wed, May 8, 11:56 PM
matheusmoreira added a dependency for D488: gpg: add the --delete-secret-key-stubs command: D487: gpg: don't delete any keys if --dry-run is passed.
Wed, May 8, 11:53 PM
matheusmoreira added a dependent revision for D487: gpg: don't delete any keys if --dry-run is passed: D488: gpg: add the --delete-secret-key-stubs command.
Wed, May 8, 11:53 PM
matheusmoreira created D488: gpg: add the --delete-secret-key-stubs command.
Wed, May 8, 11:53 PM
matheusmoreira added a dependent revision for D485: gpg: introduce the --delete-secret-subkeys command: D487: gpg: don't delete any keys if --dry-run is passed.
Wed, May 8, 11:49 PM
matheusmoreira added a dependency for D487: gpg: don't delete any keys if --dry-run is passed: D485: gpg: introduce the --delete-secret-subkeys command.
Wed, May 8, 11:49 PM
matheusmoreira created D487: gpg: don't delete any keys if --dry-run is passed.
Wed, May 8, 11:48 PM
matheusmoreira added a project to T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested): patch.
Wed, May 8, 1:08 AM · patch, Bug Report, gnupg
matheusmoreira added a comment to T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).

Diffs downloaded from the revisions don't include commit messages for some reason. Here are all the commits I submitted for review as patch files with messages:

Wed, May 8, 12:51 AM · patch, Bug Report, gnupg

Sat, May 4

matheusmoreira added a task to D485: gpg: introduce the --delete-secret-subkeys command: T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).
Sat, May 4, 10:23 PM
matheusmoreira added revisions to T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested): D485: gpg: introduce the --delete-secret-subkeys command, D486: po: add portuguese description for new command.
Sat, May 4, 10:23 PM · patch, Bug Report, gnupg
matheusmoreira added a task to D486: po: add portuguese description for new command: T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).
Sat, May 4, 10:23 PM
matheusmoreira added a dependent revision for D485: gpg: introduce the --delete-secret-subkeys command: D486: po: add portuguese description for new command.
Sat, May 4, 10:22 PM
matheusmoreira added a dependency for D486: po: add portuguese description for new command: D485: gpg: introduce the --delete-secret-subkeys command.
Sat, May 4, 10:22 PM
matheusmoreira created D486: po: add portuguese description for new command.
Sat, May 4, 10:22 PM
matheusmoreira added a dependency for D485: gpg: introduce the --delete-secret-subkeys command: D482: gpg: confirm again before deleting primary key.
Sat, May 4, 10:18 PM
matheusmoreira added a dependent revision for D482: gpg: confirm again before deleting primary key: D485: gpg: introduce the --delete-secret-subkeys command.
Sat, May 4, 10:18 PM
matheusmoreira created D485: gpg: introduce the --delete-secret-subkeys command.
Sat, May 4, 10:17 PM

Fri, May 3

matheusmoreira added a task to D482: gpg: confirm again before deleting primary key: T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).
Fri, May 3, 8:58 PM
matheusmoreira added a task to D480: gpg: factor out secret key deletion function: T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).
Fri, May 3, 8:58 PM
matheusmoreira added a task to D483: po: add portuguese primary key deletion message: T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).
Fri, May 3, 8:58 PM
matheusmoreira added revisions to T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested): D479: gpg: avoid deletion of keys not specified by user, D480: gpg: factor out secret key deletion function, D481: gpg: confirm deletion of each secret key, D482: gpg: confirm again before deleting primary key, D483: po: add portuguese primary key deletion message.
Fri, May 3, 8:58 PM · patch, Bug Report, gnupg
matheusmoreira added a task to D481: gpg: confirm deletion of each secret key: T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).
Fri, May 3, 8:58 PM
matheusmoreira added a task to D479: gpg: avoid deletion of keys not specified by user: T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).
Fri, May 3, 8:58 PM

Thu, May 2

matheusmoreira retitled D483: po: add portuguese primary key deletion message from po: add portuguese primary deletion message to po: add portuguese primary key deletion message.
Thu, May 2, 5:23 AM
matheusmoreira added a dependent revision for D482: gpg: confirm again before deleting primary key: D483: po: add portuguese primary key deletion message.
Thu, May 2, 5:23 AM
matheusmoreira added a dependency for D483: po: add portuguese primary key deletion message: D482: gpg: confirm again before deleting primary key.
Thu, May 2, 5:23 AM
matheusmoreira added a dependency for D482: gpg: confirm again before deleting primary key: D481: gpg: confirm deletion of each secret key.
Thu, May 2, 5:22 AM
matheusmoreira added a dependent revision for D481: gpg: confirm deletion of each secret key: D482: gpg: confirm again before deleting primary key.
Thu, May 2, 5:22 AM
matheusmoreira added a comment to T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).

Revision D482 adds an extra confirmation prompt before deleting the secret primary key.
Revision D483 adds portuguese translation for the primary key deletion confirmation message.

Thu, May 2, 5:22 AM · patch, Bug Report, gnupg
matheusmoreira created D483: po: add portuguese primary key deletion message.
Thu, May 2, 5:16 AM
matheusmoreira created D482: gpg: confirm again before deleting primary key.
Thu, May 2, 5:05 AM
matheusmoreira retitled D480: gpg: factor out secret key deletion function from gpg: factor out function that deletes secret keys to gpg: factor out secret key deletion function.
Thu, May 2, 4:09 AM
matheusmoreira updated the test plan for D481: gpg: confirm deletion of each secret key.
Thu, May 2, 4:04 AM
matheusmoreira updated the summary of D480: gpg: factor out secret key deletion function.
Thu, May 2, 3:43 AM
matheusmoreira updated the test plan for D479: gpg: avoid deletion of keys not specified by user.
Thu, May 2, 3:41 AM
matheusmoreira updated the diff for D480: gpg: factor out secret key deletion function.

Fix missing curly brace.

Thu, May 2, 3:28 AM

Tue, Apr 30

matheusmoreira added a dependent revision for D480: gpg: factor out secret key deletion function: D481: gpg: confirm deletion of each secret key.
Tue, Apr 30, 3:32 PM
matheusmoreira added a dependency for D481: gpg: confirm deletion of each secret key: D480: gpg: factor out secret key deletion function.
Tue, Apr 30, 3:32 PM
matheusmoreira created D481: gpg: confirm deletion of each secret key.
Tue, Apr 30, 3:32 PM
matheusmoreira retitled D480: gpg: factor out secret key deletion function from gpg: factor out function that deletes secret keys to Factor out secret key deletion function.
Tue, Apr 30, 3:20 PM
matheusmoreira added a dependency for D480: gpg: factor out secret key deletion function: D479: gpg: avoid deletion of keys not specified by user.
Tue, Apr 30, 3:18 PM
matheusmoreira added a dependent revision for D479: gpg: avoid deletion of keys not specified by user: D480: gpg: factor out secret key deletion function.
Tue, Apr 30, 3:18 PM
matheusmoreira created D480: gpg: factor out secret key deletion function.
Tue, Apr 30, 3:17 PM
matheusmoreira updated the summary of D479: gpg: avoid deletion of keys not specified by user.
Tue, Apr 30, 2:02 PM
matheusmoreira created D479: gpg: avoid deletion of keys not specified by user.
Tue, Apr 30, 1:40 PM
matheusmoreira added a comment to T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).

@werner Here are the patches:

Tue, Apr 30, 11:50 AM · patch, Bug Report, gnupg
matheusmoreira added a comment to T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).

I thought about building a list of keys targeted for deletion so gpg can then ask the user to confirm the deletion of each key individually.

Tue, Apr 30, 11:35 AM · patch, Bug Report, gnupg

Sat, Apr 27

matheusmoreira added a comment to T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).

@dkg, thanks for the feedback. I read doc/HACKING and revised the commit message so that it contains ChangeLog entries and a marker line before my description. I compared my new message to prior log entries and they seem to match now. Is this appropriate? If so, I will revise my other commits in the same manner.

Sat, Apr 27, 4:07 AM · patch, Bug Report, gnupg

Fri, Apr 26

matheusmoreira added a comment to T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).

@dkg Sure! I thought I was supposed to email the patches to the development mailing list. I've uploaded my delete-secret-subkey branch to GitHub. You can see a comparison here. I'll describe my changes.

Fri, Apr 26, 6:58 PM · patch, Bug Report, gnupg
matheusmoreira added a comment to T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).

I managed to make it work on my branch: gpg --delete-secret-key FPR! deletes just that key and no others! I will prepare a patch for this specific change and then try to implement the --delete-secret-subkeys command.

Fri, Apr 26, 5:25 AM · patch, Bug Report, gnupg

Apr 16 2019

matheusmoreira added a comment to T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).

I've been studying the source code. When a fingerprint suffixed with ! is given as argument, the do_delete_key function correctly classifies the search descriptor as exact and finds the correct key using keydb_search. However, the handle returned by keydb_get_keyblock apparently includes the primary key and all subkeys associated with it. After confirming the action with the user, the function iterates over all PKT_PUBLIC_KEY and PKT_PUBLIC_SUBKEY packets present in the keyblock, obtains the keygrip of each key and asks gpg-agent to delete it.

Apr 16 2019, 7:29 AM · patch, Bug Report, gnupg