- User Since
- Apr 13 2019, 6:37 AM (5 w, 6 d)
Wed, May 22
Tue, May 21
Committed to master: 110a4550179f
Thu, May 9
It appears this issue was first identified and triaged in 2016: T2879
If merged, my patches should resolve that task as well.
Wed, May 8
Diffs downloaded from the revisions don't include commit messages for some reason. Here are all the commits I submitted for review as patch files with messages:
Sat, May 4
Fri, May 3
Thu, May 2
Fix missing curly brace.
Tue, Apr 30
@werner Here are the patches:
Sat, Apr 27
@dkg, thanks for the feedback. I read doc/HACKING and revised the commit message so that it contains ChangeLog entries and a marker line before my description. I compared my new message to prior log entries and they seem to match now. Is this appropriate? If so, I will revise my other commits in the same manner.
Fri, Apr 26
@dkg Sure! I thought I was supposed to email the patches to the development mailing list. I've uploaded my delete-secret-subkey branch to GitHub. You can see a comparison here. I'll describe my changes.
I managed to make it work on my branch: gpg --delete-secret-key FPR! deletes just that key and no others! I will prepare a patch for this specific change and then try to implement the --delete-secret-subkeys command.
Apr 16 2019
I've been studying the source code. When a fingerprint suffixed with ! is given as argument, the do_delete_key function correctly classifies the search descriptor as exact and finds the correct key using keydb_search. However, the handle returned by keydb_get_keyblock apparently includes the primary key and all subkeys associated with it. After confirming the action with the user, the function iterates over all PKT_PUBLIC_KEY and PKT_PUBLIC_SUBKEY packets present in the keyblock, obtains the keygrip of each key and asks gpg-agent to delete it.