gpg: factor out secret key deletion function
Needs ReviewPublic
Actions

Authored by matheusmoreira on Apr 30 2019, 3:17 PM.

Details

Reviewers: None
Maniphest Tasks: T4544: More prompts before key deletion
T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested)
Commits: rKLEOPATRA5e9d402be380: Yet another place with deprecated API

Summary

g10/delkey.c (agent_delete_secret_key): New.

(do_delete_key): Use the new secret key deletion function.

The new key deletion function asks the gpg agent to delete
the secret key associated with the specified public key.
It returns GPG_ERR_NO_SECKEY if there is no secret key
associated with the given public key.

Signed-off-by: Matheus Afonso Martins Moreira <matheus.a.m.moreira@gmail.com>

Test Plan

There should be no change in the behavior of --delete-secret-key following this change.

Diff Detail

Repository

rG GnuPG

Lint

Lint Skipped

Unit

Unit Tests Skipped

Event Timeline

matheusmoreira created this revision.Apr 30 2019, 3:17 PM

matheusmoreira added a parent revision: D479: gpg: avoid deletion of keys not specified by user.

matheusmoreira retitled this revision from gpg: factor out function that deletes secret keys to Factor out secret key deletion function.Apr 30 2019, 3:20 PM

matheusmoreira added a child revision: D481: gpg: confirm deletion of each key individually.Apr 30 2019, 3:32 PM

matheusmoreira mentioned this in T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).

Fix missing curly brace.

matheusmoreira retitled this revision from gpg: avoid deletion of keys not specified by user to gpg: factor out function that deletes secret keys.May 2 2019, 3:43 AM

matheusmoreira edited the summary of this revision. (Show Details)

matheusmoreira retitled this revision from gpg: factor out function that deletes secret keys to gpg: factor out secret key deletion function.May 2 2019, 4:09 AM

matheusmoreira added a task: T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).May 3 2019, 8:58 PM

Rebased on top of master: 4c7d63cd5b02

matheusmoreira added a task: T4544: More prompts before key deletion.May 28 2019, 5:39 PM