More prompts before key deletion
Closed, WontfixPublic
Actions

Assigned To

Authored By

	matheusmoreira
	May 28 2019, 5:21 PM

Description

I added more confirmation prompts before deleting all keys and primary keys in particular.

Factor out the secret key deletion code into a static function to facilitate future changes.
Confirm the deletion of each individual key. Allows the user to delete keys interactively.
Add another confirmation prompt for primary keys. Emphasizes to the user that a primary key will be deleted.

Here are the patches:

0001-gpg-factor-out-secret-key-deletion-function.patch3 KBDownload
0002-gpg-confirm-deletion-of-each-key-individually.patch7 KBDownload
0003-gpg-confirm-again-before-deleting-primary-key.patch2 KBDownload

Details

Version: 2.2.16

Revisions and Commits

rG GnuPG
	Needs Review	D482 gpg: confirm again before deleting primary key
	Needs Review	D481 gpg: confirm deletion of each key individually
	Abandoned	D488 gpg: add the --delete-secret-key-stubs command
	Abandoned	D485 gpg: add the --delete-secret-subkeys command
	Needs Review	D480 gpg: factor out secret key deletion function

Related Objects

Mentioned Here: T7211: Kleopatra: configuration option to prohibit deletion of certificate with secret key

Event Timeline

matheusmoreira created this task.May 28 2019, 5:21 PM

matheusmoreira created this object in space S1 Public.

matheusmoreira added revisions: D480: gpg: factor out secret key deletion function, D485: gpg: add the --delete-secret-subkeys command, D488: gpg: add the --delete-secret-key-stubs command, D481: gpg: confirm deletion of each key individually, D482: gpg: confirm again before deleting primary key.May 28 2019, 5:39 PM

• werner triaged this task as Low priority.May 28 2019, 6:12 PM

matheusmoreira updated the task description. (Show Details)May 29 2019, 10:00 AM

matheusmoreira updated the task description. (Show Details)May 29 2019, 10:10 AM

matheusmoreira changed Version from 2.2.15 to 2.2.16.Jun 5 2019, 11:53 AM

In case I not already mentioned it: There won't be any new commands to delete a key. Of course you are free to change GnuPG as you like but I won't apply them here.

I am sorry for the extra work you did but nevertheless it emphasized the problem with the non-working bang syntax.

@werner Only patches 2 and 3 introduce new commands. What do you think about the other changes?

Patch 1 places the bulk of the secret key deletion code in a static function. I think it makes the code easier to understand.
Patch 4 adds prompts for each individual key. This allows the user to delete keys interactively.
Patch 5 adds an extra prompt for primary keys. This emphasizes to the user that a primary key will be deleted.

Here are the patches without any new commands:

0001-gpg-factor-out-secret-key-deletion-function.patch3 KBDownload
0002-gpg-confirm-deletion-of-each-key-individually.patch7 KBDownload
0003-gpg-confirm-again-before-deleting-primary-key.patch2 KBDownload

Would you be open to adding new options instead of new commands? I could make patches that add the --subkeys-only and --stubs-only options to the --delete[-secret]-keys commands.

matheusmoreira renamed this task from Key deletion: more prompts, new commands to More prompts before key deletion.Jun 6 2019, 5:39 AM

matheusmoreira updated the task description. (Show Details)

Nope

I think we can close this as Wontfix since it is our opinion to wont fix this issue. If there should be more prevetion of accidents it would probably be better to have the user type in "DELETE" or "YES". Anything else then another click confirming a popup. Since this will just be clicked away through muscle memory. This came up again in T7211: Kleopatra: configuration option to prohibit deletion of certificate with secret key