Differential D573
qt: Fix icon on wayland Authored by TobiasFella on Jan 10 2024, 11:45 AM.
Details
T6887: pinentry-qt: Add desktop file for wayland icon On wayland, window icons require a desktop file. To prevent pinentry from showing up as an application, it's marked with NoDisplay=true
Diff Detail
Event TimelineComment Actions I was wondering whether "Exec=pinentry" should be "Exec=pinentry-qt" because "pinentry" could be a symlink to another pinentry. On the other hand, we probably want to use the same icon also for pinentry-gtk, etc. I guess you have tested the Makefile.am changes. Ship it! Comment Actions I initially assumed the Exec line to not be relevant, since pinentry is never going to be called via the desktop file. After spending the better part of yesterday trying to figure out why capslock checking on wayland doesn't work, i understood that the exec line is highly relevant and needs to be the exact, full path to the executable. (there's also another fix incoming for capslock detection) Comment Actions pinentry-gtk etc presumably need similar treatment, so I'm not sure how much sense it makes to add org.gnupg.pinentry.desktop for pinentry-qt. Should this be org.gnupg.pinentry-qt.desktop instead? Or have one desktop file for all pinentries, which could be problematic for the Exec matching in KWin Comment Actions Right. IMO renaming the desktop file to org.gnupg.pinentry-qt.desktop is easiest, so i've done that |