Dirmngr uses a connect with timeout to allow for a shorter timeout than the TCP standard uses. Unfortunately we can't do that over Tor. To fix this we need timeout support in Libassuan's socks5_connect() function.
Description
Description
Revisions and Commits
Revisions and Commits
| rA Assuan | |||
| rA9110945ce625 Implement timeout in assuan_sock_connect_byname. | |||
Related Objects
Related Objects
- Mentioned In
- T7163: Release libassuan 3.0.0 and 3.0.1
Event Timeline
Comment Actions
assuan_sock_connect_byname may be extended to change the third argument (now int reserved) to unsigned int timeout.
It's a kind of API change, but ABI wise, the impact is minimum.
Then, internally in libassuan, socks5_connect may have timeout argument to support timeout behavior.
Comment Actions
Why can't we keep the signed int? Do we ever need such a long timeout. We could for example define -1 as use default timeout.
Comment Actions
I see the point of use of int.
For backward compatibility, the semantics of 0 should remain as default timeout (let kernel decide == 120 sec, usually), -1 would be meaning immediately (only success when local).
Comment Actions
Actually, it's not 'connect' system call, but 'CONNECT' request which matters. The use of SOCKS in libassuan is that it always connects to SOCKS server at localhost.
So, other than the special case of erroneous configuration of TOR, introducing timeout handling to the initial connection to the SOCKS server makes less sense.
Timeout here should mean client side timeout for asking 'CONNECT' request to SOCKS server.