'make check' with uninstalled library, which is building now (even if rpath doesn't work well)
Closed, ResolvedPublic

Description

libgpg-error, libgcrypt, libassuan, gpgme and libksba don't allow 'make check' with the particular library being built, when rpath doesn't wok well.
(npth does.)

This is due to having AM_LDFLAGS = -no-install in tests/Makefile.am.

If it's good to support 'make check' with not-yet-installed library, let us remove the line. Doing this, it will work even if rpath doesn't work well. That's because with no -no-install, libtool will create wrapper script with LD_LIBRARY_PATH.

I know that it's only the particular library in question, and the cause of this problem is not ours but binutils and libtool.

It's true that when we do for libraries in bootstrap process, installing library is required.

gniibe created this task.Thu, Dec 20, 2:51 AM
gniibe renamed this task from Use uninstalled library, which is building now to Use uninstalled library, which is building now (even if rpath doesn't work well).Thu, Dec 20, 3:05 AM
gniibe updated the task description. (Show Details)
gniibe updated the task description. (Show Details)
gniibe updated the task description. (Show Details)Thu, Dec 20, 3:07 AM
gniibe updated the task description. (Show Details)
gniibe set External Link to https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=859732.Thu, Dec 20, 3:11 AM
gniibe added a comment.EditedThu, Dec 20, 3:38 AM

For binutils, in Stretch, Debian specific patch was introduced.
Then, upstream introduced --enable-new-dtags option for configure to build binutils.
Now, Debian uses --enable-new-dtags option (at build time).

gniibe updated the task description. (Show Details)Thu, Dec 20, 3:40 AM
gniibe updated the task description. (Show Details)Thu, Dec 20, 3:42 AM

Reading this discussion: http://lists.gnu.org/archive/html/bug-libtool/2018-01/msg00014.html
It seems that it could be fixed if we care about the order of libraries.
And it's not the issue for libgpg-error, which doesn't require external libraries.

gniibe added a comment.Mon, Jan 7, 8:08 AM

My tentative conclusion: When (GNU) ld supports --disable-new-dtags, add it to LDADD in tests/Makefile.am.

gniibe added a comment.Tue, Jan 8, 2:50 AM

For other distros, it seems it's quite old issue: https://sourceware.org/ml/binutils/2012-05/msg00037.html

Topic branch of libgpg-error is not good to show changes (for other libraries).
So, I made D473: Introducing LDADD_FOR_TESTS_KLUDGE to enable 'make check' with LD_LIBRARY_PATH.
Appliying to libgpg-error.

gniibe removed a project: gpgrt.Thu, Jan 10, 2:32 AM

Done for libgpg-error.

gniibe renamed this task from Use uninstalled library, which is building now (even if rpath doesn't work well) to 'make check' with uninstalled library, which is building now (even if rpath doesn't work well).Thu, Jan 10, 2:33 AM
aheinecke triaged this task as Normal priority.Mon, Jan 14, 10:31 AM
aheinecke added a subscriber: aheinecke.

I give this normal priority to move it out of the "Needs Triage" queue.

Done for libgcrypt.

gniibe removed a project: gpgme.Wed, Jan 16, 3:03 AM

Done for gpgme.

gniibe closed this task as Resolved.

Done for libassuan and libksba.