'make check' with uninstalled library, which is building now (even if rpath doesn't work well)
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• gniibe
	Dec 20 2018, 2:51 AM

Description

libgpg-error, libgcrypt, libassuan, gpgme and libksba don't allow 'make check' with the particular library being built, when rpath doesn't wok well.
(npth does.)

This is due to having AM_LDFLAGS = -no-install in tests/Makefile.am.

If it's good to support 'make check' with not-yet-installed library, let us remove the line. Doing this, it will work even if rpath doesn't work well. That's because with no -no-install, libtool will create wrapper script with LD_LIBRARY_PATH.

I know that it's only the particular library in question, and the cause of this problem is not ours but binutils and libtool.

It's true that when we do for libraries in bootstrap process, installing library is required.

Details

External Link: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=859732

Revisions and Commits

rK libksba
	rK3f99f332ada6 build: With LD_LIBRARY_PATH defined, use --disable-new-dtags.
rC libgcrypt
	rCe5c2f8a2cd2b build: With LD_LIBRARY_PATH defined, use --disable-new-dtags.
rA Assuan
	rA23bf87595432 build: With LD_LIBRARY_PATH defined, use --disable-new-dtags.
rPTH nPth
	rPTH2501a48930eb build: With LD_LIBRARY_PATH defined, use --disable-new-dtags.
rE libgpg-error
	rE1fd997231b71 build: Build with LD_LIBRARY_PATH, use of DT_RPATH (2/2).
rM GPGME
	rM66bcb8acb245 build: With LD_LIBRARY_PATH defined, use --disable-new-dtags.

Related Objects

Mentioned In: T4943: Release LibKSBA 1.4.0
T4376: Release gpgme 1.13.0
T4361: Release Libassuan 2.5.3
T4243: Test failure in libgcrypt-1.8.4
T4296: Release libgpg-error 1.34
Mentioned Here: D473: Introducing LDADD_FOR_TESTS_KLUDGE to enable 'make check' with LD_LIBRARY_PATH

Event Timeline

• gniibe created this task.Dec 20 2018, 2:51 AM

• gniibe renamed this task from Use uninstalled library, which is building now to Use uninstalled library, which is building now (even if rpath doesn't work well).Dec 20 2018, 3:05 AM

• gniibe updated the task description. (Show Details)

• gniibe updated the task description. (Show Details)Dec 20 2018, 3:07 AM

• gniibe updated the task description. (Show Details)

• gniibe set External Link to https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=859732.Dec 20 2018, 3:11 AM

For binutils, in Stretch, Debian specific patch was introduced.
Then, upstream introduced --enable-new-dtags option for configure to build binutils.
Now, Debian uses --enable-new-dtags option (at build time).

• gniibe updated the task description. (Show Details)Dec 20 2018, 3:40 AM

• gniibe updated the task description. (Show Details)Dec 20 2018, 3:42 AM

Reading this discussion: http://lists.gnu.org/archive/html/bug-libtool/2018-01/msg00014.html
It seems that it could be fixed if we care about the order of libraries.
And it's not the issue for libgpg-error, which doesn't require external libraries.

My tentative conclusion: When (GNU) ld supports --disable-new-dtags, add it to LDADD in tests/Makefile.am.

My patches on the topic branch: https://dev.gnupg.org/source/libgpg-error/history/gniibe%252Fdisable-new-dtags/

For other distros, it seems it's quite old issue: https://sourceware.org/ml/binutils/2012-05/msg00037.html

Topic branch of libgpg-error is not good to show changes (for other libraries).
So, I made D473: Introducing LDADD_FOR_TESTS_KLUDGE to enable 'make check' with LD_LIBRARY_PATH.
Appliying to libgpg-error.

Done for libgpg-error.

• gniibe added a commit: rE1fd997231b71: build: Build with LD_LIBRARY_PATH, use of DT_RPATH (2/2)..Jan 10 2019, 2:33 AM

• gniibe renamed this task from Use uninstalled library, which is building now (even if rpath doesn't work well) to 'make check' with uninstalled library, which is building now (even if rpath doesn't work well).Jan 10 2019, 2:33 AM

aheinecke awarded a token.Jan 10 2019, 7:35 AM