Kleopatra: Missing error handling when changing expiry
Testing, NormalPublic
Actions

Assigned To

Authored By

	aheinecke
	Mar 7 2019, 10:42 AM

Description

In Kleopatra when you change the expiry of a Key and enter a wrong passphrase or cancel the pinentry it still reports a success.

Details

Version: master

Revisions and Commits

rM GPGME
	rMf66f856c89b7 core: Add error handling to setexpire

Related Objects

Mentioned In: T4653: Kleopatra - Change Expiry Date
T3990: Kleopatra change expiry date on year doesn't work
Mentioned Here: T3990: Kleopatra change expiry date on year doesn't work

Event Timeline

aheinecke created this task.Mar 7 2019, 10:42 AM

From a comment in T3990

Hi，aheinecke。my kleopatra version is "kleopatra Version 3.1.4-gpg4win-3.1.5".and when change expiry date, i enter a wrong passphrase or choose "cancle". it shows successfully. what can i do for solve this question. thanks.

aheinecke mentioned this in T3990: Kleopatra change expiry date on year doesn't work.Mar 7 2019, 10:46 AM

Hello,

I'm not sure yet where the bug lives. It's either in GPGME's editkeyinteractor that ignores the error / cancel or in Kleopatra itself. I'll have to look into it. Btw. I do not think that this should have high priority because it is not a new regression and while it is a Bug and wrong it is not really harmful.

If you want to fix it yourself the first step would probably be to compile Kleopatra / GPGME for a developer version. This is very complicated. There is documentation for this in https://dev.gnupg.org/source/gpg4win/browse/master/README but you will need a debian linux system for it.

Best Regards,
Andre

huowen added a comment.Mar 8 2019, 3:10 AM

This comment was removed by huowen.

@werner This issue also applies to GPA. Looking at the edit key interface I can't see how we can handle this. Am I overlooking something or do we just loose the error information / is it not emited by gnupg?

Hello,
when can we fix it?

Best wishes
Huo

Werner: I'm assigning this to you. Because the underlying reason is a missing status from gpg. I think we should add that for 2.3 as any new status line tends to break things.

aheinecke merged a task: T4653: Kleopatra - Change Expiry Date.Jul 24 2019, 9:46 AM

aheinecke mentioned this in T4653: Kleopatra - Change Expiry Date.

aheinecke added a subscriber: jeffb255.

Taking: Still does not work although now --quick-set-expire is used by gpgme.

ikloecker added a commit: rMf66f856c89b7: core: Add error handling to setexpire.Aug 14 2020, 11:51 AM

Fixed.