Page MenuHome GnuPG
Create Task
Maniphest T5239

Add UI for managing groups
Closed, ResolvedPublic
Actions

Revisions and Commits

rLIBKLEO Libkleo
rLIBKLEO611cd4fb69e3 Allow retrieving and saving of configurable groups of keys
rLIBKLEOb70c7f47aa29 Allow removing a group of keys
rLIBKLEO82b040177c36 Move most code of update() to private implementation
rLIBKLEOe9c893fbd80f Allow adding a group of keys
rLIBKLEO6838d7c9763b Factor out function for getting the fingerprints of a group of keys
rLIBKLEO40783b456776 Take care of immutable entries when updating a group of keys
rLIBKLEOa951e71fc5cf Allow removing a group from the model
rLIBKLEOb81d6c8cbfb6 Allow adding a group to the model
rLIBKLEOc676a618c4bb Allow updating a group in the model
rLIBKLEOd79cfe916da7 Identify groups of keys by source and a source dependent identifier
rLIBKLEOec7d08c6fbc1 Add setters for name and keys to KeyGroup
rLIBKLEOcef028c24d31 Allow updating a group of keys
rLIBKLEO74f4a32ba89f Add a unique, runtime-constant identifier to groups
rLIBKLEOa512cb35183c Allow adding/removing keys to/from a group of keys
rLIBKLEO9b88be979703 Store keys of a group as set instead of vector
rKLEOPATRA Kleopatra
rKLEOPATRA88a63502f33c Show key details on double click on a key in either list
rKLEOPATRAdf4ce8109044 Fix lost selection and current item when switching view mode
rKLEOPATRA0f3b374b6e22 Use tree views for key lists in group dialog
rKLEOPATRA6242e6e7b07a Add a separate configuration dialog for configuring groups of keys
rKLEOPATRA1a22db0afdfa Update certificate lineedit if the selected group was removed
rKLEOPATRA1df9407578e2 Show comment for groups read from the configuration of gpg
rKLEOPATRAcd691f05637a Remove Edit button from group details dialog
rKLEOPATRA5ff134b27f46 Add a configuration module for configuring groups of keys
rKLEOPATRA2e51be87b274 Allow setting the widget that shall have the initial focus
rKLEOPATRA9873a5a4cfba Identify updated group of keys by source and source dependent identifier
rKLEOPATRAc99ec64fa3c0 Give initial keyboard focus to the keys filter
rKLEOPATRAb8130ea5f2ef Allow changing the name of a group of keys
rKLEOPATRA71980f217e7f Add command for editing a group of keys
rKLEOPATRAfda5f44e6dd6 Update updated group in certificate lineedit
rKLEOPATRAd736c350ad22 Add button for editing group to group details dialog
rKLEOPATRA15fb36c3edde Add dialog for editing groups of keys
rKLEOPATRAeb7a1909ae42 Adapt to changed interface of KeyGroup

Related Objects
Search...

Event Timeline

ikloecker created this task.Jan 14 2021, 10:37 AM
aheinecke added a subtask: T5273: Release Gpg4win 4.x.x.Jan 28 2021, 10:39 AM
ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Feb 1 2021, 5:15 PM
ikloecker added a commit: rLIBKLEO9b88be979703: Store keys of a group as set instead of vector.Feb 9 2021, 9:44 AM
ikloecker added a commit: rLIBKLEOa512cb35183c: Allow adding/removing keys to/from a group of keys.
ikloecker added a commit: rLIBKLEO74f4a32ba89f: Add a unique, runtime-constant identifier to groups.
ikloecker added a commit: rLIBKLEOcef028c24d31: Allow updating a group of keys.
ikloecker added a commit: rKLEOPATRAeb7a1909ae42: Adapt to changed interface of KeyGroup.Feb 9 2021, 9:47 AM
ikloecker added a commit: rKLEOPATRA15fb36c3edde: Add dialog for editing groups of keys.
ikloecker added a commit: rKLEOPATRAd736c350ad22: Add button for editing group to group details dialog.
ikloecker added a commit: rKLEOPATRAfda5f44e6dd6: Update updated group in certificate lineedit.
ikloecker added a comment.Feb 9 2021, 10:02 AM

Added a first version of the UI. Key list still needs to be changed from a simple list view to the usual multi-column tree view.

Currently, the dialog for editing groups can only be opened from the group details dialog (which can be opened by clicking on the icon shown in the encryption recipient input field).

ikloecker added a commit: rLIBKLEOec7d08c6fbc1: Add setters for name and keys to KeyGroup.Feb 10 2021, 1:37 PM
ikloecker added a commit: rKLEOPATRA71980f217e7f: Add command for editing a group of keys.Feb 10 2021, 1:44 PM
ikloecker added a commit: rKLEOPATRAb8130ea5f2ef: Allow changing the name of a group of keys.
ikloecker added a commit: rKLEOPATRAc99ec64fa3c0: Give initial keyboard focus to the keys filter.
ikloecker added a commit: rLIBKLEOd79cfe916da7: Identify groups of keys by source and a source dependent identifier.Feb 18 2021, 1:42 PM
ikloecker added a commit: rLIBKLEOc676a618c4bb: Allow updating a group in the model.
ikloecker added a commit: rLIBKLEOb81d6c8cbfb6: Allow adding a group to the model.
ikloecker added a commit: rLIBKLEOa951e71fc5cf: Allow removing a group from the model.
ikloecker added a commit: rLIBKLEO40783b456776: Take care of immutable entries when updating a group of keys.
ikloecker added a commit: rLIBKLEO6838d7c9763b: Factor out function for getting the fingerprints of a group of keys.
ikloecker added a commit: rLIBKLEOe9c893fbd80f: Allow adding a group of keys.
ikloecker added a commit: rLIBKLEO82b040177c36: Move most code of update() to private implementation.
ikloecker added a commit: rLIBKLEOb70c7f47aa29: Allow removing a group of keys.
ikloecker added a commit: rLIBKLEO611cd4fb69e3: Allow retrieving and saving of configurable groups of keys.
ikloecker added a commit: rKLEOPATRA9873a5a4cfba: Identify updated group of keys by source and source dependent identifier.Feb 18 2021, 5:01 PM
ikloecker added a commit: rKLEOPATRA2e51be87b274: Allow setting the widget that shall have the initial focus.
ikloecker added a commit: rKLEOPATRA5ff134b27f46: Add a configuration module for configuring groups of keys.
ikloecker added a commit: rKLEOPATRAcd691f05637a: Remove Edit button from group details dialog.
ikloecker added a commit: rKLEOPATRA1df9407578e2: Show comment for groups read from the configuration of gpg.
ikloecker added a commit: rKLEOPATRA1a22db0afdfa: Update certificate lineedit if the selected group was removed.
ikloecker added a commit: rKLEOPATRA6242e6e7b07a: Add a separate configuration dialog for configuring groups of keys.Feb 23 2021, 10:06 AM
ikloecker added a commit: rKLEOPATRAdf4ce8109044: Fix lost selection and current item when switching view mode.Feb 24 2021, 3:12 PM
ikloecker added a commit: rKLEOPATRA0f3b374b6e22: Use tree views for key lists in group dialog.
ikloecker added a commit: rKLEOPATRA88a63502f33c: Show key details on double click on a key in either list.
ikloecker changed the task status from Open to Testing.Feb 24 2021, 3:28 PM
ikloecker reassigned this task from ikloecker to aheinecke.

I think this is now ready for testing.

Open questions:

  1. The UI lists only groups defined in Kleopatra's configuration. Should groups that are defined in gpg.conf also be listed (as read-only)?
  2. Should it be possible to make copies of groups? This would be useful for migrating old groups defined in gpg.conf. But it may also cause problems if people make copies of immutable groups that are defined in the global system configuration.
aheinecke added a comment.Feb 24 2021, 3:45 PM

Hi, thanks I'll give it a spin tomorrow.

In T5239#143724, @ikloecker wrote:
  1. The UI lists only groups defined in Kleopatra's configuration. Should groups that are defined in gpg.conf also be listed (as read-only)?

I don't think so. The groups in gpg.conf so far were more of an expert feature as there was no gui for this and anyone who reads the gpg manpage is in my opinion an expert user. So I don't think we should put any effort in that.

  1. Should it be possible to make copies of groups? This would be useful for migrating old groups defined in gpg.conf. But it may also cause problems if people make copies of immutable groups that are defined in the global system configuration.

Yes I think that would be nice to have if it is not too much trouble. Even without the migration use case. The use case I am thinking of is more that you have a group "Department X" and you Copy it as "Project Y" and then add some external keys to the Project but you still have your "baseline" department group.

ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Feb 25 2021, 10:24 AM
ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Oct 20 2021, 4:36 PM
ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Oct 25 2021, 11:46 AM
aheinecke closed this task as Resolved.May 9 2022, 9:21 AM
aheinecke closed subtask T5273: Release Gpg4win 4.x.x as Resolved.May 9 2022, 9:29 AM
• ebo moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Apr 5 2023, 3:00 PM