Kleopatra: Add support for custom groups
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	aheinecke
	Dec 10 2020, 9:38 AM

Description

As discussed:

The use case is that you have a project and have several keys both S/MIME and OpenPGP that are related to a project. The Project identifier can be a Mail address or a generic Name.

Kleopatra should offer user interface to Add both S/MIME and OpenPGP keys to a Group.
The Groups should be easily selectable when setting up recipients for file encryption.

The groups can be stored by kleopatra. Ideally the API for them would be in libkleopatra so that they can be easily respected in KMail and Outlook (which use libkleopatra).

Autocompletion for group names should work in the recipient selection dialog.

The Groups should complement tags which use the remark feature on OpenPGP certifications but don't rely on that because we need S/MIME and OpenPGP combinations.

Revisions and Commits

rLIBKLEO Libkleo
	rLIBKLEOd0a44035ca0e Allow enabling/disabling group support in the key cache
	rLIBKLEO006fa0f861c2 Improve summary line for groups of keys
	rLIBKLEO611cd4fb69e3 Allow retrieving and saving of configurable groups of keys
	rLIBKLEOb70c7f47aa29 Allow removing a group of keys
	rLIBKLEO82b040177c36 Move most code of update() to private implementation
	rLIBKLEOe9c893fbd80f Allow adding a group of keys
	rLIBKLEO6838d7c9763b Factor out function for getting the fingerprints of a group of keys
	rLIBKLEO40783b456776 Take care of immutable entries when updating a group of keys
	rLIBKLEOa951e71fc5cf Allow removing a group from the model
	rLIBKLEOb81d6c8cbfb6 Allow adding a group to the model
	rLIBKLEOc676a618c4bb Allow updating a group in the model
	rLIBKLEOd79cfe916da7 Identify groups of keys by source and a source dependent identifier
	rLIBKLEO8e189f7a9fb6 Add QDebug stream operator for KeyGroup
	rLIBKLEOec7d08c6fbc1 Add setters for name and keys to KeyGroup
	rLIBKLEOcef028c24d31 Allow updating a group of keys
	rLIBKLEO89cbb4ea423f Remove duplicate keys from the result of getGroupKeys()
	rLIBKLEO74f4a32ba89f Add a unique, runtime-constant identifier to groups
	rLIBKLEOa512cb35183c Allow adding/removing keys to/from a group of keys
	rLIBKLEO9b88be979703 Store keys of a group as set instead of vector
	rLIBKLEOa8e571990ab7 Make the summary line of groups of keys unambiguous by adding information about…
	rLIBKLEO72ef0d9f9d2d Add support for groups of keys with identical names
	rLIBKLEO166cc951f5eb Optionally, read groups from a file
	rLIBKLEOe7800fd5c2fa Provide icon representing the validity of a group of keys
	rLIBKLEO6b761e51fbb2 Nicely format some properties of/information about groups of keys
	rLIBKLEO9b19b0b6562d Return a const reference of the group's keys instead of a copy
	rLIBKLEOcd8669ecdf56 Fix HierarchicalKeyListModel::index() for group items
	rLIBKLEOaa623c0add65 Add summary line for key groups and use it in the key list model
	rLIBKLEO0cb40f92f5be Return only valid keys for the given indexes
	rLIBKLEO94474eecc9d9 Optionally, include the groups from the key cache in the key list model
	rLIBKLEO3fecb75b258e Make list of groups available via KeyCache
	rLIBKLEO8401ffee101c Deduplicate tests of key list models
	rLIBKLEOf4709427cd2c Add support for groups of keys to HierarchicalKeyListModel
	rLIBKLEO06efd641239f Add support for groups of keys to FlatKeyListModel
	rLIBKLEO6f4cfbeb1571 Allow setting groups of keys
	rLIBKLEOd649b946094f Add support for groups of keys to AbstractKeyListModel::data()
	rLIBKLEOb8753c249bc8 Only clear state related to keys when setting or removing keys
	rLIBKLEO0ee0a52b7d5e Add support for groups of keys to KeyListModelInterface
	rLIBKLEOd3127adfaf21 Add value class representing a group of keys
	rLIBKLEOa0d1ba917c0a Deduplicate tests of key list models
	rLIBKLEOfd34d2a69325 Add basic support for groups of keys to HierarchicalKeyListModel
	rLIBKLEO028ef1e5e8fe Add basic support for groups of keys to FlatKeyListModel
	rLIBKLEOcda12d791e97 Add basic test for group support of flat key list model
	rLIBKLEO11bea1a3145c Add basic support for groups of keys to FlatKeyListModel
	rLIBKLEO2f59672ff4c6 Add basic support for groups of keys to FlatKeyListModel
rKLEOPATRA Kleopatra
	rKLEOPATRAba9d373c2c7b Hide "Configure Groups..." option if group support is disabled
	rKLEOPATRA4640882a6759 Enable/disable group support in key cache depending on the setting
	rKLEOPATRAd458669f993a Enable group support by default for non-Windows builds
	rKLEOPATRA88a63502f33c Show key details on double click on a key in either list
	rKLEOPATRA0f3b374b6e22 Use tree views for key lists in group dialog
	rKLEOPATRAdf4ce8109044 Fix lost selection and current item when switching view mode
	rKLEOPATRAc8f1fad15b08 Keep current key or group as long as they match
	rKLEOPATRA6242e6e7b07a Add a separate configuration dialog for configuring groups of keys
	rKLEOPATRA1a22db0afdfa Update certificate lineedit if the selected group was removed
	rKLEOPATRA1df9407578e2 Show comment for groups read from the configuration of gpg
	rKLEOPATRAcd691f05637a Remove Edit button from group details dialog
	rKLEOPATRA5ff134b27f46 Add a configuration module for configuring groups of keys
	rKLEOPATRA2e51be87b274 Allow setting the widget that shall have the initial focus
	rKLEOPATRA9873a5a4cfba Identify updated group of keys by source and source dependent identifier
	rKLEOPATRAb8130ea5f2ef Allow changing the name of a group of keys
	rKLEOPATRAc99ec64fa3c0 Give initial keyboard focus to the keys filter
	rKLEOPATRA71980f217e7f Add command for editing a group of keys
	rKLEOPATRAfda5f44e6dd6 Update updated group in certificate lineedit
	rKLEOPATRAd736c350ad22 Add button for editing group to group details dialog
	rKLEOPATRA15fb36c3edde Add dialog for editing groups of keys
	rKLEOPATRAeb7a1909ae42 Adapt to changed interface of KeyGroup
	rKLEOPATRA4c3dfe9a3eda Show group details when user clicks on validity icon
	rKLEOPATRA29a6e85e75c3 Add dialog showing the keys of a group of keys
	rKLEOPATRAfe8ea25f3124 Allow saving/restoring layout of key list to/from custom config group
	rKLEOPATRA2d8a67f2195c Tell KeyCache to read key groups from kleopatragroupsrc
	rKLEOPATRA790ec8abf69b Provide tooltips and show validity icon for entered group of keys
	rKLEOPATRA8322aa636952 Use config setting instead of build variable to enable group support
	rKLEOPATRAee51092adf2c Allow selection of groups of keys for encryption
	rKLEOPATRA9e5aebf7a991 Add support for groups of keys to CertificateSelectionDialog
	rKLEOPATRA9b4480ea5da3 Ignore group items when expanding/collapsing items in KeyTreeView
	rKLEOPATRA9cb843144a01 Add setter for a group of keys to CertificateLineEdit
	rKLEOPATRA75d5c5f81707 Move handling of dialogs from CertificateLineEdit to SignEncryptWidget
	rKLEOPATRA5fc494bc6424 Add support for groups of keys to SignEncryptWidget
	rKLEOPATRA810d92231203 Add support for groups of keys to CertificateLineEdit
	rKLEOPATRA15724dabb9e5 Add support for groups of keys to SignEncryptWidget
	rKLEOPATRA4563ccd73952 Add support for groups of keys to CertificateLineEdit

Related Objects
Search...

Status	Assigned	Task
Resolved	aheinecke	T5175 Kleopatra: Add support for custom groups
Resolved	ikloecker	T5238 Add basic support for groups to the key list models
Resolved	aheinecke	T5239 Add UI for managing groups
Wontfix	ikloecker	T5240 Allow selection of groups implicitly defined by tags
Resolved	aheinecke	T5241 Allow selection of groups as recipients for file encryption
Resolved	aheinecke	T5273 Release Gpg4win 4.x.x
Resolved	ikloecker	T5242 Groups are loaded from a file
Resolved	ikloecker	T5249 Allow selection of groups defined in gpg's configuration
Resolved	• ebo	T5638 Make Kleopatra group configuration exportable

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

ikloecker added a commit: rLIBKLEO028ef1e5e8fe: Add basic support for groups of keys to FlatKeyListModel.Jan 18 2021, 4:45 PM

ikloecker added a commit: rLIBKLEOfd34d2a69325: Add basic support for groups of keys to HierarchicalKeyListModel.

ikloecker added a commit: rLIBKLEOa0d1ba917c0a: Deduplicate tests of key list models.

ikloecker created subtask T5249: Allow selection of groups defined in gpg's configuration.Jan 19 2021, 12:11 PM

ikloecker added a commit: rLIBKLEOd3127adfaf21: Add value class representing a group of keys.Jan 20 2021, 11:35 AM

ikloecker added a commit: rLIBKLEO0ee0a52b7d5e: Add support for groups of keys to KeyListModelInterface.

ikloecker added a commit: rLIBKLEOb8753c249bc8: Only clear state related to keys when setting or removing keys.

ikloecker added a commit: rLIBKLEOd649b946094f: Add support for groups of keys to AbstractKeyListModel::data().

ikloecker added a commit: rLIBKLEO6f4cfbeb1571: Allow setting groups of keys.

ikloecker added a commit: rLIBKLEO06efd641239f: Add support for groups of keys to FlatKeyListModel.

ikloecker added a commit: rLIBKLEOf4709427cd2c: Add support for groups of keys to HierarchicalKeyListModel.

ikloecker added a commit: rLIBKLEO8401ffee101c: Deduplicate tests of key list models.

ikloecker added a commit: rLIBKLEO3fecb75b258e: Make list of groups available via KeyCache.

ikloecker added a commit: rLIBKLEO94474eecc9d9: Optionally, include the groups from the key cache in the key list model.

ikloecker added a commit: rKLEOPATRA810d92231203: Add support for groups of keys to CertificateLineEdit.

ikloecker added a commit: rKLEOPATRA5fc494bc6424: Add support for groups of keys to SignEncryptWidget.

ikloecker closed subtask T5238: Add basic support for groups to the key list models as Resolved.Jan 20 2021, 12:14 PM

ikloecker added a commit: rLIBKLEO0cb40f92f5be: Return only valid keys for the given indexes.Jan 20 2021, 5:54 PM

ikloecker added a commit: rKLEOPATRA75d5c5f81707: Move handling of dialogs from CertificateLineEdit to SignEncryptWidget.Jan 21 2021, 6:13 PM

ikloecker added a commit: rLIBKLEOaa623c0add65: Add summary line for key groups and use it in the key list model.Jan 25 2021, 4:03 PM

ikloecker added a commit: rLIBKLEOcd8669ecdf56: Fix HierarchicalKeyListModel::index() for group items.

ikloecker added a commit: rKLEOPATRA9cb843144a01: Add setter for a group of keys to CertificateLineEdit.Jan 26 2021, 12:33 PM

ikloecker added a commit: rKLEOPATRA9b4480ea5da3: Ignore group items when expanding/collapsing items in KeyTreeView.

ikloecker added a commit: rKLEOPATRA9e5aebf7a991: Add support for groups of keys to CertificateSelectionDialog.

ikloecker added a commit: rKLEOPATRAee51092adf2c: Allow selection of groups of keys for encryption.

ikloecker added a commit: rKLEOPATRA8322aa636952: Use config setting instead of build variable to enable group support.

ikloecker added a commit: rLIBKLEO9b19b0b6562d: Return a const reference of the group's keys instead of a copy.Jan 26 2021, 5:08 PM

ikloecker added a commit: rLIBKLEO6b761e51fbb2: Nicely format some properties of/information about groups of keys.

ikloecker added a commit: rLIBKLEOe7800fd5c2fa: Provide icon representing the validity of a group of keys.Jan 27 2021, 11:32 AM

ikloecker added a commit: rKLEOPATRA790ec8abf69b: Provide tooltips and show validity icon for entered group of keys.Jan 27 2021, 11:44 AM

ikloecker closed subtask T5249: Allow selection of groups defined in gpg's configuration as Resolved.Jan 27 2021, 1:51 PM

ikloecker changed the status of subtask T5241: Allow selection of groups as recipients for file encryption from Open to Testing.Jan 27 2021, 1:56 PM

ikloecker added a commit: rLIBKLEO166cc951f5eb: Optionally, read groups from a file.Jan 28 2021, 12:00 PM

ikloecker added a commit: rKLEOPATRA2d8a67f2195c: Tell KeyCache to read key groups from kleopatragroupsrc.Jan 28 2021, 1:56 PM

ikloecker added a commit: rLIBKLEO72ef0d9f9d2d: Add support for groups of keys with identical names.Feb 1 2021, 1:11 PM

ikloecker added a commit: rLIBKLEOa8e571990ab7: Make the summary line of groups of keys unambiguous by adding information about….

ikloecker closed subtask T5242: Groups are loaded from a file as Resolved.Feb 1 2021, 5:15 PM

ikloecker added a commit: rKLEOPATRAfe8ea25f3124: Allow saving/restoring layout of key list to/from custom config group.Feb 2 2021, 4:22 PM

ikloecker added a commit: rKLEOPATRA29a6e85e75c3: Add dialog showing the keys of a group of keys.

ikloecker added a commit: rKLEOPATRA4c3dfe9a3eda: Show group details when user clicks on validity icon.

ikloecker added a commit: rLIBKLEO9b88be979703: Store keys of a group as set instead of vector.Feb 9 2021, 9:44 AM

ikloecker added a commit: rLIBKLEOa512cb35183c: Allow adding/removing keys to/from a group of keys.

ikloecker added a commit: rLIBKLEO74f4a32ba89f: Add a unique, runtime-constant identifier to groups.

ikloecker added a commit: rLIBKLEO89cbb4ea423f: Remove duplicate keys from the result of getGroupKeys().

ikloecker added a commit: rLIBKLEOcef028c24d31: Allow updating a group of keys.

ikloecker added a commit: rKLEOPATRAeb7a1909ae42: Adapt to changed interface of KeyGroup.Feb 9 2021, 9:47 AM

ikloecker added a commit: rKLEOPATRA15fb36c3edde: Add dialog for editing groups of keys.

ikloecker added a commit: rKLEOPATRAd736c350ad22: Add button for editing group to group details dialog.

ikloecker added a commit: rKLEOPATRAfda5f44e6dd6: Update updated group in certificate lineedit.

Where should groups be listed? Should groups be listed in the main key/certificates view?

ikloecker added a commit: rLIBKLEOec7d08c6fbc1: Add setters for name and keys to KeyGroup.Feb 10 2021, 1:37 PM

ikloecker added a commit: rKLEOPATRA71980f217e7f: Add command for editing a group of keys.Feb 10 2021, 1:44 PM

ikloecker added a commit: rKLEOPATRAb8130ea5f2ef: Allow changing the name of a group of keys.

ikloecker added a commit: rKLEOPATRAc99ec64fa3c0: Give initial keyboard focus to the keys filter.

ikloecker added a commit: rLIBKLEO8e189f7a9fb6: Add QDebug stream operator for KeyGroup.Feb 18 2021, 1:42 PM

ikloecker added a commit: rLIBKLEOd79cfe916da7: Identify groups of keys by source and a source dependent identifier.

ikloecker added a commit: rLIBKLEOc676a618c4bb: Allow updating a group in the model.

ikloecker added a commit: rLIBKLEOb81d6c8cbfb6: Allow adding a group to the model.

ikloecker added a commit: rLIBKLEOa951e71fc5cf: Allow removing a group from the model.

ikloecker added a commit: rLIBKLEO40783b456776: Take care of immutable entries when updating a group of keys.

ikloecker added a commit: rLIBKLEO6838d7c9763b: Factor out function for getting the fingerprints of a group of keys.

ikloecker added a commit: rLIBKLEOe9c893fbd80f: Allow adding a group of keys.

ikloecker added a commit: rLIBKLEO82b040177c36: Move most code of update() to private implementation.

ikloecker added a commit: rLIBKLEOb70c7f47aa29: Allow removing a group of keys.

ikloecker added a commit: rLIBKLEO611cd4fb69e3: Allow retrieving and saving of configurable groups of keys.

ikloecker added a commit: rKLEOPATRA9873a5a4cfba: Identify updated group of keys by source and source dependent identifier.Feb 18 2021, 5:01 PM

ikloecker added a commit: rKLEOPATRA2e51be87b274: Allow setting the widget that shall have the initial focus.

ikloecker added a commit: rKLEOPATRA5ff134b27f46: Add a configuration module for configuring groups of keys.

ikloecker added a commit: rKLEOPATRAcd691f05637a: Remove Edit button from group details dialog.

ikloecker added a commit: rKLEOPATRA1df9407578e2: Show comment for groups read from the configuration of gpg.

ikloecker added a commit: rKLEOPATRA1a22db0afdfa: Update certificate lineedit if the selected group was removed.

ikloecker added a commit: rKLEOPATRA6242e6e7b07a: Add a separate configuration dialog for configuring groups of keys.Feb 23 2021, 10:06 AM

ikloecker added a commit: rKLEOPATRAc8f1fad15b08: Keep current key or group as long as they match.Feb 23 2021, 3:53 PM

ikloecker added a commit: rLIBKLEO006fa0f861c2: Improve summary line for groups of keys.Feb 23 2021, 4:16 PM

ikloecker added a commit: rKLEOPATRAdf4ce8109044: Fix lost selection and current item when switching view mode.Feb 24 2021, 3:12 PM

ikloecker added a commit: rKLEOPATRA0f3b374b6e22: Use tree views for key lists in group dialog.

ikloecker added a commit: rKLEOPATRA88a63502f33c: Show key details on double click on a key in either list.

ikloecker changed the status of subtask T5239: Add UI for managing groups from Open to Testing.Feb 24 2021, 3:28 PM

aheinecke merged a task: T4040: Kleopatra: Add support for groups.Mar 1 2021, 9:48 AM

aheinecke mentioned this in T4040: Kleopatra: Add support for groups.

aheinecke added a subscriber: philiperm.

I am happy with the result, this seems very workable. Especially the Group Details dialog is a nice touch to inspect a group.

I'm not sure if we should show the groups additionally in the keylist. As you asked here earlier (sorry I overlooked that message). We can probably discuss that and how problematic that would be in our weekly standup.

ikloecker added a commit: rLIBKLEOd0a44035ca0e: Allow enabling/disabling group support in the key cache.Mar 3 2021, 10:28 AM

ikloecker added a commit: rKLEOPATRAd458669f993a: Enable group support by default for non-Windows builds.Mar 3 2021, 10:32 AM

ikloecker added a commit: rKLEOPATRAba9d373c2c7b: Hide "Configure Groups..." option if group support is disabled.

ikloecker added a commit: rKLEOPATRA4640882a6759: Enable/disable group support in key cache depending on the setting.

ikloecker changed the task status from Open to Testing.May 10 2021, 9:30 AM

ikloecker reassigned this task from ikloecker to aheinecke.

ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.

ikloecker added a subscriber: ikloecker.

• werner added a subtask: T5638: Make Kleopatra group configuration exportable.Oct 5 2021, 4:37 PM

ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Oct 20 2021, 4:36 PM

ikloecker changed the status of subtask T5638: Make Kleopatra group configuration exportable from Open to Testing.Nov 17 2021, 12:27 PM

ikloecker closed subtask T5240: Allow selection of groups implicitly defined by tags as Wontfix.Apr 20 2022, 9:49 AM