Page MenuHome GnuPG
Create Task
Maniphest T5430

"free(): invalid pointer" from --clearsign
Closed, ResolvedPublic
Actions

Description

Observed in 2.3.1:

It seems using --clearsign creates some memory corruption. To reproduce, set MALLOC_CHECK_=2 and (probably not required) MALLOC_PERTURB_=21 before running the test suite. First failing check is <standard>/ tests/openpgp/clearsig.scm.

The error is most likely triggered in the final xfree (afx); statement in armor.c:release_armor_context. I have no reason to assume this was fixed since the 2.3.1 release.

Revisions and Commits

rG GnuPG
rGac731dbbbd21 gpg: Fix allocation for EXTRAHASH.

Related Objects

Event Timeline

cbiedl created this task.May 10 2021, 9:27 PM
• gniibe added a commit: rGac731dbbbd21: gpg: Fix allocation for EXTRAHASH..May 11 2021, 7:50 AM
• gniibe added a subscriber: • gniibe.May 11 2021, 7:50 AM

Sorry, it's my fault.
Fixed in rGac731dbbbd21: gpg: Fix allocation for EXTRAHASH..

• gniibe changed the task status from Open to Testing.May 11 2021, 8:43 AM
• gniibe triaged this task as Normal priority.
• werner added a subscriber: • werner.May 11 2021, 9:00 AM

FWIW, we can and should run our test suite under valgrind from time to time

make check TESTFLAGS=--parallel with_valgrind=1
• werner closed this task as Resolved.Aug 24 2021, 7:55 PM
• werner mentioned this in T5405: Release GnuPG 2.3.2.