Page MenuHome GnuPG
Create Task
Maniphest T5546

Kleopatra: After importing the first pubkey for a card from LDAP the keylistview is not refreshed
Open, LowPublic
Actions

Description

When starting with a fresh keyring and inserting a smartcard that has a key on ldap after the import the keylistview is not refreshed and still shows the welcomewidget.

Revisions and Commits

rLIBKLEO Libkleo
rLIBKLEO4d7c53d59885 Fix watching for files that are removed and then re-added
rLIBKLEO2fd71da00d5f Add function returning list of folders to watch for changes
rLIBKLEO1dbd2b55b574 Add the secret key files to the whitelist of files to watch
rKLEOPATRA Kleopatra
rKLEOPATRA20177db4a448 Watch all relevant folders for changes

Related Objects

Event Timeline

aheinecke triaged this task as Normal priority.Aug 4 2021, 2:10 PM
aheinecke created this task.
ikloecker claimed this task.Oct 20 2021, 10:32 AM
ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
ikloecker reassigned this task from ikloecker to aheinecke.Oct 20 2021, 11:20 AM
ikloecker added a project: Info Needed.
ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
ikloecker added a subscriber: ikloecker.

I tried to reproduce this. Experimentally, I added P15CardWidget::searchPGPFpr() to OpenPGPKeyCardWidget, commented out the code that checks for an LDAP keyserver and called the function with a fixed fingerprint.

First experiment:

  1. I started Kleopatra with an OpenPGP card already inserted.
  2. Kleopatra did the key lookup and import, and then the welcome widget was replaced by the key list listing the imported key.

Second experiment:

  1. I started Kleopatra without OpenPGP card inserted.
  2. Kleopatra showed the welcome widget.
  3. I inserted an OpenPGP card, switched to the Smartcards view, and pressed F5.
  4. Kleopatra did the key lookup and import.
  5. I switched back to the Certificates view.
  6. Kleopatra showed the key list listing the imported key.

I don't see what should be different for a lookup via LDAP or for a P15 card instead of an OpenPGP card.

Needs more info how to reproduce.

• werner lowered the priority of this task from Normal to Low.Oct 20 2021, 12:26 PM
• werner added a project: scd.
• werner added a subscriber: • werner.

Lets downgrade the priority and keep it open in case we get reports from customers. The other option would be to replicate this here using our AD demo network. But that is a bit time consuming.

ikloecker claimed this task.Apr 27 2022, 11:18 AM
ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.

I had a look at the file system watcher we use to react on changes in the GnuPG home directory. It doesn't watch the private keys living in private-keys-v1.d. Moreover, it does not handle the removal of files properly.

ikloecker added a commit: rLIBKLEO2fd71da00d5f: Add function returning list of folders to watch for changes.Apr 27 2022, 12:03 PM
ikloecker added a commit: rLIBKLEO1dbd2b55b574: Add the secret key files to the whitelist of files to watch.
ikloecker added a commit: rLIBKLEO4d7c53d59885: Fix watching for files that are removed and then re-added.
ikloecker added a commit: rKLEOPATRA20177db4a448: Watch all relevant folders for changes.Apr 27 2022, 1:01 PM
ikloecker removed ikloecker as the assignee of this task.Apr 27 2022, 1:22 PM
ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.

The issues mentioned in the previous comment have been fixed.

OTOH, those issues shouldn't have caused the original problem because the import from LDAP also touches the public key ring file and therefore Kleopatra should have performed a refresh. Therefore, I'm leaving this task open. Feel free to close.

ikloecker mentioned this in T6829: Kleopatra: Loop reading keys from smartcard.Nov 20 2023, 1:26 PM