Page MenuHome GnuPG
Create Task
Maniphest T5547

Single thread support with newer GNU C library (2.34 or later)
Closed, ResolvedPublic
Actions

Description

I just noticed that in newer GNU C library, our method to detect if an application is single threaded or not doesn't work (not supported) any more.

Applications should check the __libc_single_threaded variable declared in <sys/single_threaded.h> instead.

We need to fix our implementation.

Details

External Link
https://sourceware.org/git/?p=glibc.git;a=blob;f=NEWS;hb=505a964ae00eb6d24144d070cb7fe9fbab6d1393#l740

Revisions and Commits

rE libgpg-error
rE2b476b3ebc1d tests: Add a test for locking when single thread.
rE67595e8244ed posix-lock: Support GNU C library 2.34 or later.
rE8538a83fd1b5 m4: Merge our local change for threadlib.m4.
rE7ad1ff9673e4 m4: Update m4/threadlib.m4 from gnulib.

Related Objects

Event Timeline

• gniibe created this task.Aug 5 2021, 8:29 AM
• gniibe added a project: libgcrypt.
• gniibe updated the task description. (Show Details)
• gniibe edited projects, added gpgrt; removed libgcrypt.Aug 5 2021, 8:34 AM
• gniibe added a comment.Aug 5 2021, 8:53 AM

We also need to update m4/threadlib.m4.
Now, it's maintained in gnulib.
See the changes in:
https://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=12b5b00f93c6433c3df8176fc9674d7600f8b268

• gniibe added a comment.Aug 6 2021, 4:17 AM

Here is the documentation of the new way of single-threaded execution:
https://www.gnu.org/software/libc/manual/html_node/Single_002dThreaded.html

• gniibe added a commit: rE7ad1ff9673e4: m4: Update m4/threadlib.m4 from gnulib..Aug 6 2021, 7:13 AM
• gniibe added a commit: rE8538a83fd1b5: m4: Merge our local change for threadlib.m4..
• gniibe added a commit: rE67595e8244ed: posix-lock: Support GNU C library 2.34 or later..
• gniibe renamed this task from Single thread support with newer GNU C library (2.32 or later) to Single thread support with newer GNU C library (2.34 or later).Aug 6 2021, 9:19 AM
• gniibe claimed this task.
• gniibe triaged this task as Normal priority.
• gniibe added a project: Restricted Project.
• gniibe closed this task as Resolved.Aug 26 2021, 6:37 AM
• gniibe removed a project: Restricted Project.

Added a test, and tested with glibc 2.32 by manual editing config.h for USE_POSIX_THREADS_FROM_LIBC.
Works correctly.

• gniibe added a commit: rE2b476b3ebc1d: tests: Add a test for locking when single thread..Aug 26 2021, 8:26 AM
• werner mentioned this in T5352: Release libgpg-error 1.43.Nov 3 2021, 3:16 PM