Page MenuHome GnuPG
Create Task
Maniphest T5913

libgcrypt: bug fix for PPC bulk AES-GCM acceleratieration, missing HWF_PPC_ARCH_3_10 in HW feature
Closed, ResolvedPublic
Actions

Description

To fix the HW feature, HWF_PPC_ARCH_3_10, did not include in the ppc-features list. Without this HW feature list, bulk operation never got invoked.

Revisions and Commits

rC libgcrypt
rCe073f0ed4466 hwf-ppc: fix missing HWF_PPC_ARCH_3_10 in HW feature
rC29bfb3ebbc63 hwf-ppc: fix missing HWF_PPC_ARCH_3_10 in HW feature

Related Objects

Event Timeline

dannytsen created this task.Mar 31 2022, 9:52 PM
dannytsen created this object in space S1 Public.
dannytsen added a comment.Mar 31 2022, 9:55 PM

gcrypt_bugfix.patch374 BDownload

Added the HWF_PPC_ARCH_3_10 list in ppc_features[] in src/hwf-ppc.c.

• werner assigned this task to jukivili.Mar 31 2022, 10:46 PM
• werner added projects: libgcrypt, ppc.
jukivili added a comment.EditedApr 1 2022, 8:51 AM

Looks like that line went missing in third/final version of AES-GCM patch at https://dev.gnupg.org/T5700

jukivili added a commit: rC29bfb3ebbc63: hwf-ppc: fix missing HWF_PPC_ARCH_3_10 in HW feature.Apr 1 2022, 8:54 AM
jukivili added a comment.Apr 1 2022, 8:55 AM

Fixed in master. I rechecked that bulk implementation passes tests with qemu-ppc64le.

dannytsen added a comment.Apr 1 2022, 2:08 PM

Hi Jussi, yes for some reason, it went missing, I was checking performance numbers and found out the line went missing. Thanks.

jukivili closed this task as Resolved.Apr 19 2022, 5:59 PM
jukivili added a commit: rCe073f0ed4466: hwf-ppc: fix missing HWF_PPC_ARCH_3_10 in HW feature.Fri, Jan 30, 10:43 AM