I fully agree. I also think that the separate recipient tab are rather annoying, in particular, because I usually want to select the recipients before I write the text. Accessibility will also benefit if all inputs can be reached easily with the Tab key without the need to switch between different tabs.

also, in the recipient tab the "encrypt with passphrase" option is at the very bottom and so far away from the other options that it is easily overlooked, if the window is fullsized.

Another thing we noticed today is that the pgpOnly check that determines if S/MIME and PGP or only PGP is shown (The radio buttons at the top right corner) is done only at initialization. So if you import your first S/MIME certs it will still only offer PGP certs and no option to switch. Just as a note here instead of a different issue because it is mostly for testing but should be improved on an update.

When looking at Carl's first MR I had a few ideas/thoughts:

• Does the notepad really need to support S/MIME? People might want to use inline PGP with Kleopatra, but S/MIME???
• I wondering whether we should move the checkboxes to the group box titles and get rid of the group boxes and instead use KSeparators to separate the different sections, i.e.

[ ] Prove authenticity (sign)
Sign as:
------------------------------
[ ] Encrypt
Encrypt for me:
Encrypt for others:
------------------------------
[ ] Encrypt with password
Anyone ...
------------------------------
[Sign and Encrypt]

Does the notepad really need to support S/MIME? People might want to use inline PGP with Kleopatra, but S/MIME???

Agree

I wondering whether we should move the checkboxes to the group box titles and get rid of the group boxes and instead use KSeparators to separate the different sections, i.e.

Also agree

In T5957#192566, @CarlSchwan wrote:

Does the notepad really need to support S/MIME? People might want to use inline PGP with Kleopatra, but S/MIME???

Agree

Werner does not agree. I myself have no idea if people use this.
I guess your main concern is to get rid of the buttons OpenPGP/S/MIME?

I can't comment on Ingo's other suggestion with the group boxes, as I don't know what the implications are, so feedback for that will have to wait for a screenshot.

Okay, then we keep the protocol radio buttons for now, but I guess there's no reason not to make it less prominent. I would even argue that the label "Protocol:" isn't really helpful and could be removed.

I'd have no objections against making it less prominent.
Instead of the "Protocol" label we could then maybe add a tooltip/info to the buttons with something like "the protocol to be used".
I know, tooltips are not popular with you ;-)

But what I don't understand is: why do we need the buttons? For other encryption actions in Kleo you can choose from all available keys, regardless of their protocol.

I played a bit with the right pane to make it less wide. Here is how it looks (still WIP)

In T5957#192598, @ebo wrote:

But what I don't understand is: why do we need the buttons? For other encryption actions in Kleo you can choose from all available keys, regardless of their protocol.

Because if we encrypt files it's easy to have multiple different result files, e.g. file.gpg which is signed&encrypted with the OpenPGP keys, file.p7m which is encrypted (but not signed) with the S/MIME certificates and file.p7s which is signed (but not encrypted) with the S/MIME certificates. For the notepad we don't have the option to have multiple results because the result is displayed in the single notepad text field

Sure, we could concatenate multiple results or introduce multiple result text fields. In fact, with a separate notepad window this may even be an option to open multiple notepad windows for the different results.

But currently the notepad can only have a single input and a single output. It's not possible to encrypt with OpenPGP and S/MIME. And it's not possible to sign and encrypt with S/MIME (because there's no simple combined sign&encrypt in S/MIME).

I'm wondering if/how we can get rid of the checkbox before "Encrypt for me". Do we even need to distinguish between "for me" and "for others"? It has always felt wrong to me that we have completely different UI for selecting my single (!) key and multiple other keys. What if I want to encrypt to two keys of me? Makes no sense to enter my second key under "Encrypt for others". What if somebody always wants to encrypt everything to two of their keys, e.g. because they use different keys on different devices? But that also applies to the file encryption dialog so maybe that's a different discussion.

And simpler solution for the checkbox problem could be

[ ] Prove authenticity (sign)
Sign as:
[ combo box ]

[ ] Encrypt for me
[ combo box ]

Encrypt for others
[ input field ]
...

[ ] Encrypt with password
Anyone ...

The only thing that's a bit ugly is that there's no checkbox in front of "Encrypt for others" because it's mostly superfluous/redundant to the presence or absence of "other" certificates.

And I'm wondering if we really need the "Sign as" label.

The only thing that's a bit ugly is that there's no checkbox in front of "Encrypt for others" because it's mostly superfluous/redundant to the presence or absence of "other" certificates.

I think this is fine.

Here is how this looks to have split the encrypt in two categories.

With title separator

Without title separator

Some follow up tasks: T7361: notepad: Move to an external window T7355: Keyboard navigation inside the Notepad text editor and T7362: notepad: Clipboard and filesystem integration