Page MenuHome GnuPG
Create Task
Maniphest T6062

Kleopatra: Kleopatra fails with error if signed data is not found
Closed, ResolvedPublic
Actions

Description

When verifying a detached signature Kleopatra and the original file does not exist Kleopatra does not ask the user to identify the file that should be verified but fails with an Input/Output error:

On Linux the behavior is different and it falls back to the old decrypt/verify dialog which offers a file selection. But for usability I think it would be best if we directly show a file selection dialog for the user to pick the file that should be verified. This would be most intuitive in my opinion.

Revisions and Commits

rKLEOPATRA Kleopatra
rKLEOPATRAa214bd6ffb2b Properly terminate decrypt/verify operation if user cancels it
rKLEOPATRA18bede6f4565 Disable Decrypt/Verify button if required files do not exist
rKLEOPATRA1161f2addf73 Simplify code
rKLEOPATRAb427bfd5bd0f Fix check if signed file corresponding to detached signature exists
rKLEOPATRAa3abf3ab1adf Use correct folder when asking for file to verify

Event Timeline

aheinecke triaged this task as Normal priority.Jul 6 2022, 10:30 AM
aheinecke created this task.
ikloecker claimed this task.Jul 7 2022, 9:46 AM
ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
ikloecker added a comment.EditedJul 7 2022, 9:55 AM

Actually, I get a very similar error message on Linux, if I run kleopatra --verify <detached signature file>

An error occurred: Kleopatra: Could not open file ".../detached-sig-with-different-name/verify-me-signatur.txt" for reading: No such file or directory (218136657)

ikloecker added a commit: rKLEOPATRAa3abf3ab1adf: Use correct folder when asking for file to verify.Jul 7 2022, 10:24 AM
ikloecker added a commit: rKLEOPATRAb427bfd5bd0f: Fix check if signed file corresponding to detached signature exists.
ikloecker changed the task status from Open to Testing.Jul 7 2022, 10:28 AM
ikloecker removed ikloecker as the assignee of this task.
ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
ikloecker added a project: Restricted Project.
ikloecker added a subscriber: ikloecker.

Fixed. This was actually a regression introduced many years ago.

Note that this was only broken in the code path used when running kleopatra --verify <file>.

ikloecker added a commit: rKLEOPATRA1161f2addf73: Simplify code.Jul 7 2022, 11:50 AM
ikloecker added a commit: rKLEOPATRA18bede6f4565: Disable Decrypt/Verify button if required files do not exist.
ikloecker added a comment.Jul 7 2022, 11:53 AM

I have also improved the workflow when verifying detached signatures without corresponding signed file from Kleopatras UI in "non-automatic" mode, i.e. if "Automatically start operation based on input detection for decrypt/verify." is disabled in the settings.

ikloecker added a commit: rKLEOPATRAa214bd6ffb2b: Properly terminate decrypt/verify operation if user cancels it.Jul 7 2022, 12:01 PM
ikloecker renamed this task from Kleoaptra: On Windows Kleopatra fails with IO error if signed data is not found to Kleopatra: Kleopatra fails with error if signed data is not found.Jul 7 2022, 12:03 PM
werner removed a project: Restricted Project.Sep 22 2022, 10:52 AM
• hunterthompson added a subscriber: • hunterthompson.May 1 2023, 10:57 AM
This comment was removed by werner.
werner added a subscriber: werner.May 2 2023, 12:43 PM
werner added a comment.May 2 2023, 12:49 PM

That comment was used to sneak in an ad. For documentation here is the comment w/o the link:
The changes made to the code have improved the workflow when verifying detached signature [redacted] without a corresponding signed file from Kleopatra's UI, which should make the process more intuitive for users. It is possible that users who experienced this issue in the past may express their satisfaction with the fix in the comments, while others may provide feedback on the usability of the updated workflow.

ebo closed this task as Resolved.Wed, Sep 27, 3:44 PM
ebo claimed this task.
ebo moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
ebo added a subscriber: ebo.

works