Page MenuHome GnuPG
Create Task
Maniphest T6157

Kleopatra: Fix potential invalidation of the keys a command works on when the key cache is refreshed
Closed, ResolvedPublic
Actions

Description

See T6154: Kleopatra: Assert in CertifyCertificateCommand after setting ownertrust of key for an example of this problem.

This problem should really be fixed in the Command base class, so that it doesn't happen for any other concrete commands. The idea is to keep references to the selected key(s) instead of keeping the indexes of the selected key(s) because the indexes will become invalid when the key list model is reset after a refresh of the key cache.

Revisions and Commits

rKLEOPATRA Kleopatra
rKLEOPATRAc6245adec6c4 Simplify c'tor taking a key
rKLEOPATRAf19ed1756917 Set key instead of index for DetailsCommand
rKLEOPATRA019f687a069b Store selected keys instead of their indexes
rKLEOPATRAc963a702ec21 Remove unused methods

Related Objects

Event Timeline

ikloecker triaged this task as Normal priority.Aug 24 2022, 2:07 PM
ikloecker created this task.
ikloecker added projects: kleopatra, Restricted Project.Aug 29 2022, 11:21 AM
ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Sep 12 2022, 9:41 AM
ikloecker added a commit: rKLEOPATRAc963a702ec21: Remove unused methods.Sep 12 2022, 1:05 PM
ikloecker added a commit: rKLEOPATRA019f687a069b: Store selected keys instead of their indexes.
ikloecker added a commit: rKLEOPATRAf19ed1756917: Set key instead of index for DetailsCommand.
ikloecker added a commit: rKLEOPATRAc6245adec6c4: Simplify c'tor taking a key.
ikloecker closed this task as Resolved.Sep 12 2022, 1:48 PM

All commands should work as before (or more robust if a key listing happens while the command is running). Setting to resolved because there isn't anything that can or should be tested specifically.

• canti59 added a commit: rG8046fcac63db: po: Update Czech translation..Oct 14 2022, 2:10 AM
• gniibe removed a commit: rG8046fcac63db: po: Update Czech translation..Oct 14 2022, 2:50 AM