Maniphest T6154

Kleopatra: Assert in CertifyCertificateCommand after setting ownertrust of key
Closed, ResolvedPublic
Actions

Assigned To
• ebo
Authored By
• aheinecke
Aug 24 2022, 11:30 AM
Tags
Subscribers
• aheinecke
• ebo
• ikloecker

Description

In CertifyCertificateCommand::Private::createJob we have observed triggering the assert:

Q_ASSERT(key().protocol() == OpenPGP);

This was reproducible by:

  • Editing a secret key with gpg --edit-key
  • set trust to unkown
  • certify another key in Kleopatra
  • Select "yes" in the question box to mark this key as your own
  • Confirm the dialog

I was able to reproduce it about 4 times but after adding some debug output I could no longer reproduce it. Now I can neiter reproduce it on Windows nor on Linux even with unchanged binaries. So it might be that this problem was there for longer but is a timing issue that we only noticed now in pre release testing.

Revisions and Commits

rKLEOPATRA Kleopatra
rKLEOPATRA800c22f7f4a2 Keep a reference to the key to certify

Related Objects

Event Timeline

• aheinecke triaged this task as High priority.Aug 24 2022, 11:30 AM
• aheinecke created this task.
• ikloecker added a commit: rKLEOPATRA800c22f7f4a2: Keep a reference to the key to certify.Aug 24 2022, 2:00 PM
• ikloecker changed the task status from Open to Testing.Aug 24 2022, 2:01 PM
• ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
• ikloecker added a project: Restricted Project.
• ikloecker added a subscriber: • ikloecker.

Should be fixed.

I'll create a spin-off for fixing this key invalidation problem for all commands.

• ikloecker mentioned this in T6157: Kleopatra: Fix potential invalidation of the keys a command works on when the key cache is refreshed.Aug 24 2022, 2:07 PM
• ikloecker mentioned this in T6156: Kleopatra: Aborting password entry on certify leads to broken error message.Aug 24 2022, 2:52 PM
• werner removed a project: Restricted Project.Sep 22 2022, 10:46 AM
• canti59 added a commit: rG8046fcac63db: po: Update Czech translation..Oct 14 2022, 2:10 AM
• gniibe removed a commit: rG8046fcac63db: po: Update Czech translation..Oct 14 2022, 2:50 AM
• ebo closed this task as Resolved.Jun 15 2023, 1:38 PM
• ebo claimed this task.
• ebo moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
• ebo added a subscriber: • ebo.

could not trigger it with the described steps on windows