Kleopatra: no error if trying to write decrypted file to write-protected folder
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	ebo
	May 19 2023, 4:21 PM

Description

With Kleopatra choose decrypt+ verify for a file. In dialog window choose a write protected folder as destination. Click save.

Expected behavior: An error should be shown to the user.

But there is no error message for the user, Debugview:

[7088] org.kde.pim.kleopatra: 0x9674af0 renaming "C:/Users/g10code.WIN-TEST3/AppData/Local/Temp/kleopatra-ScJFOC/test_ä.txt.jXPBlq" -> "C:/Users/g10code.WIN-TEST3/AppData/Local/Temp/kleopatra-ScJFOC/test_ä.txt"
[7088] org.kde.pim.kleopatra: 0x9674af0 succeeded
[7088] org.kde.pim.kleopatra: Collection Progress:  1000  total:  1000
[7088] org.kde.pim.kleopatra: Collection Progress:  1000  total:  1000
[7088] org.kde.pim.libkleo: not showing link (not available)
[7088] org.kde.pim.kleopatra: All done
[7088] org.kde.pim.kleopatra: ("test_ä.txt")
[7088] org.kde.pim.kleopatra: Moving  "C:/Users/g10code.WIN-TEST3/AppData/Local/Temp/kleopatra-ScJFOC/test_ä.txt"  to  "Z:/kann_weg/test_ä.txt"
[7088] org.kde.pim.kleopatra: 
[7088] org.kde.pim.kleopatra: Error:  "Die Datei „C:\\Users\\g10code.WIN-TEST3\\AppData\\Local\\Temp\\kleopatra-ScJFOC\\test_ä.txt“ kann nicht nach „Z:\\kann_weg\\test_ä.txt“ verschoben werden."

Edit: removed irrelevant part where the destination triggered Windows' Virtual Store feature.
Edit: @werner messed things up and reverted his edits. See T6503

Details

Version: Gpg4win-4.1.1-beta317

Revisions and Commits

rKLEOPATRA Kleopatra
	rKLEOPATRAdfc181cfa2bf Use NTFS permissions check to check if output folder is writable
	rKLEOPATRA8d603b8766c9 Add helper to check if file is (really) writable (on Windows)
	rKLEOPATRAd8c9c135e21a Use NTFS permissions check to check if output folder is writable
	rKLEOPATRA70dc090a004e Improve error messages for unacceptable output folders
	rKLEOPATRA50477d05a8cb Add helper to check if file is (really) writable (on Windows)

Related Objects

Mentioned Here: T6503: Do not make use of the VirtualStore under Windows
T6488: Kleopatra: moving decrypted Folder to USB device fails

Event Timeline

ebo created this task.May 19 2023, 4:21 PM

~~At least the first part~~ seems to be identical behavior to that described in T6488 for USB devices.

ebo updated the task description. (Show Details)May 23 2023, 10:48 AM

werner added a subscriber: werner.May 23 2023, 12:42 PM

This comment was removed by werner.

werner renamed this task from Kleopatra: no error if trying to write decrypted file to write-protected folder to Do not make use of the VirtualStore under Windows..May 23 2023, 12:43 PM

werner triaged this task as High priority.

werner added projects: gnupg24, gnupg22.

werner updated the task description. (Show Details)

werner renamed this task from Do not make use of the VirtualStore under Windows. to Kleopatra: no error if trying to write decrypted file to write-protected folder.May 23 2023, 1:17 PM

werner updated the task description. (Show Details)

werner removed projects: gnupg22, gnupg24.

ikloecker claimed this task.May 30 2023, 2:15 PM

ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.May 31 2023, 9:21 AM

Kleopatra explicitly checks if the output folder is writable using QFileInfo::isWritable. But: QFileInfo::isWritable mentions that NTFS permissions are not checked unless this is enabled explicitly (because it's an expensive operation). I'll try to enable it locally for the check.

ikloecker added a commit: rKLEOPATRA50477d05a8cb: Add helper to check if file is (really) writable (on Windows).May 31 2023, 10:52 AM

ikloecker added a commit: rKLEOPATRA70dc090a004e: Improve error messages for unacceptable output folders.

ikloecker added a commit: rKLEOPATRAd8c9c135e21a: Use NTFS permissions check to check if output folder is writable.

ikloecker added a commit: rKLEOPATRA8d603b8766c9: Add helper to check if file is (really) writable (on Windows).

ikloecker added a commit: rKLEOPATRAdfc181cfa2bf: Use NTFS permissions check to check if output folder is writable.

The output folder is now checked with enabled NTFS permissions check for writability. Hopefully, this fixes the problem on Windows.

For the upcoming gpg4win release I have kept the existing messages. For the next release the error messages have been improved.

works:

ebo closed this task as Resolved.Jun 7 2023, 3:36 PM

ebo claimed this task.

ebo moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.