Kleopatra: moving decrypted Folder to USB device fails
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• ebo
	May 15 2023, 4:24 PM

Description

Decrypting a tar.gpg archive file with standard settings apparently works:

But after clicking "Save all", there is no further information shown to the user and no new Folder appears on the USB stick.

Debugview shows:

[8136] org.kde.pim.kleopatra: Moving "C:/Users/g10code.WIN-TEST3/AppData/Local/Temp/kleopatra-AtABCN/Program Files (x86)" to "F:/Program Files (x86)_1"
[8136] org.kde.pim.kleopatra: 
[8136] org.kde.pim.kleopatra: Error:  "<html><p>Die Datei ‘<tt>C:\\Users\\g10code.WIN-TEST3\\AppData\\Local\\Temp\\kleopatra-AtABCN\\Program Files (x86)</tt>’ kann nicht nach ‘<tt>F:\\Program Files (x86)_1</tt>’ verschoben werden.</p>\n\n<p><i>Zugriff verweigert auf F:/Program Files (x86)_1.</i></p></html>"

(Note: That is F:\ and not C:\)

Details

Version: Gpg4win-4.1.1-beta317

Revisions and Commits

rKLEOPATRA Kleopatra
	rKLEOPATRA7f8cb8371ecd Take hidden files into account when copying/removing files/folders
	rKLEOPATRA72ceb4227ff2 On Windows, revert to using our own helper for moving folders
	rKLEOPATRA4ca1d4ced18a Make the path helpers available on Windows only
	rKLEOPATRAebc39866fefb Revert "Remove obsolete helpers"
	rKLEOPATRA03c6eae82b38 Take hidden files into account when copying/removing files/folders
	rKLEOPATRA4f84606811fb On Windows, revert to using our own helper for moving folders
	rKLEOPATRA7201cabc365b Make the path helpers available on Windows only
	rKLEOPATRA2f1a05ff83d1 Revert "Remove obsolete helpers"

Related Objects

Mentioned In: T6537: Make KIO::move work on Windows when moving between different partitions
T6499: Kleopatra: no error if trying to write decrypted file to write-protected folder
Mentioned Here: T3547: Kleopatra: Failure to move decrypted folders to differen partition
T6373: Kleopatra: Show progress dialog when moving decrypted archive to final destination

Event Timeline

• ebo created this task.May 15 2023, 4:24 PM

• ebo triaged this task as High priority.May 17 2023, 12:33 PM

Before you ask: I can write on that device and it works with gpgtar on the commandline:

gpgtar -v --status-fd 2 -C f: -d c:\Users\g10code.WIN-TEST3\Documents\testordner.tar.gpg

• ebo mentioned this in T6499: Kleopatra: no error if trying to write decrypted file to write-protected folder.May 23 2023, 8:43 AM

• werner updated the task description. (Show Details)May 23 2023, 1:25 PM

• werner updated the task description. (Show Details)

So the reason this fails is the same as it was back when T3547 was fixed. MoveFile does not work across directories, and even MoveFileEx that supports this for files does not support this for directories.

kio/src/ioslaves/file/file_win.cpp just does a plain MoveFile ( https://learn.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-movefileexa ) in their code sadly there is also no recursive copy in that code so I would need to extend that with the code from Kleopatra. Which Ingo wanted to remove because it had some issues. T6373

What I find confusing is that in kio/core/copyjob.cpp I get a debug line saying in startRenameJob:
" qCDebug(KIO_COPYJOB_DEBUG) << m_currentSrcURL << "->" << dest << "trying direct rename first";"

As if there would be a fallback if direct rename does not work. But I don't see it.

So the good news is that I know how to solve this issue by going back to the old code, but I would like to talk to ingo about how the old code could / should be improved first before.

ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.May 30 2023, 9:59 AM

ikloecker added a commit: rKLEOPATRA2f1a05ff83d1: Revert "Remove obsolete helpers".May 30 2023, 11:29 AM

ikloecker added a commit: rKLEOPATRA7201cabc365b: Make the path helpers available on Windows only.

ikloecker added a commit: rKLEOPATRA4f84606811fb: On Windows, revert to using our own helper for moving folders.

ikloecker added a commit: rKLEOPATRA03c6eae82b38: Take hidden files into account when copying/removing files/folders.

ikloecker added a commit: rKLEOPATRAebc39866fefb: Revert "Remove obsolete helpers".May 30 2023, 11:50 AM

ikloecker added a commit: rKLEOPATRA4ca1d4ced18a: Make the path helpers available on Windows only.

ikloecker added a commit: rKLEOPATRA72ceb4227ff2: On Windows, revert to using our own helper for moving folders.

ikloecker added a commit: rKLEOPATRA7f8cb8371ecd: Take hidden files into account when copying/removing files/folders.

Fixed as suggested by Andre. Additionally, I have added support for hidden files in the old code (which are probably not really a thing on Windows). The downside is that there is no progress on Windows (as before the switch to using KIO::move).

works (at least for small directories)

ikloecker mentioned this in T6537: Make KIO::move work on Windows when moving between different partitions.Jun 15 2023, 12:05 PM

works for 4,1 GB, too.
(Tested with Gpg4win-4.2.0-beta346)