Page MenuHome GnuPG
Create Task
Maniphest T6373

Kleopatra: Show progress dialog when moving decrypted archive to final destination
Testing, HighPublic
Actions

Description

Noticed while working on T5478: Kleopatra: Performance problems decrypting and encrypting large Archives.

The Verify/Decrypt dialog is closed immediately after clicking Save although moving the decrypted archive from the temporary folder to the final destination folder may take quite some time. I noticed this when I deleted the destination folder after a test and then Kleopatra reported an error when copying the files.

To make the user aware that the operation is still running in the background we should show a progress dialog or keep the dialog open (showing a progress bar) until the operation is complete.

Revisions and Commits

rKLEOPATRA Kleopatra
rKLEOPATRA26f01cf32094 Remove obsolete helpers
rKLEOPATRA32a30acd7d41 Use KIO::moveAs to move decrypted folders to the target folder
rKLEOPATRA8da2c9acf38d Sort/group libraries to link
rKLEOPATRA39754005e5b3 Look for all KF libraries with a single find_package command
rKLEOPATRAedf8ae06ff84 Let the compiler control the lifetime of the dialog

Related Objects
Search...

Event Timeline

ikloecker triaged this task as High priority.Feb 14 2023, 10:36 AM
ikloecker created this task.
aheinecke added a comment.Feb 14 2023, 10:42 AM

Oh, yes this makes sense in the copy/delete path of utils/path-helper.cpp Kleo::moveDir on Windows src and dest are usually on the same device so this might not have been noticed as much by our users as then it is just a rename.

ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Mar 13 2023, 8:20 AM
ikloecker added a commit: rKLEOPATRAedf8ae06ff84: Let the compiler control the lifetime of the dialog.Mar 15 2023, 9:20 AM
ikloecker added a commit: rKLEOPATRA39754005e5b3: Look for all KF libraries with a single find_package command.Mar 15 2023, 11:50 AM
ikloecker added a commit: rKLEOPATRA8da2c9acf38d: Sort/group libraries to link.
ikloecker added a commit: rKLEOPATRA32a30acd7d41: Use KIO::moveAs to move decrypted folders to the target folder.
ikloecker added a commit: rKLEOPATRA26f01cf32094: Remove obsolete helpers.
ikloecker changed the task status from Open to Testing.Mar 16 2023, 10:20 AM
ikloecker removed ikloecker as the assignee of this task.
ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.

I think letting KIO show the progress is okay for now. I hope it also works on Windows (if showing progress is necessary).

aheinecke mentioned this in T6488: Kleopatra: moving decrypted Folder to USB device fails.Fri, May 26, 11:56 AM