Page MenuHome GnuPG

Kleopatra: Show progress dialog when moving decrypted archive to final destination
Open, NormalPublic

Description

Noticed while working on T5478: Kleopatra: Performance problems decrypting and encrypting large Archives.

The Verify/Decrypt dialog is closed immediately after clicking Save although moving the decrypted archive from the temporary folder to the final destination folder may take quite some time. I noticed this when I deleted the destination folder after a test and then Kleopatra reported an error when copying the files.

To make the user aware that the operation is still running in the background we should show a progress dialog or keep the dialog open (showing a progress bar) until the operation is complete.

Event Timeline

ikloecker created this task.

Oh, yes this makes sense in the copy/delete path of utils/path-helper.cpp Kleo::moveDir on Windows src and dest are usually on the same device so this might not have been noticed as much by our users as then it is just a rename.

ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Mar 13 2023, 8:20 AM
ikloecker changed the task status from Open to Testing.Mar 16 2023, 10:20 AM
ikloecker removed ikloecker as the assignee of this task.
ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.

I think letting KIO show the progress is okay for now. I hope it also works on Windows (if showing progress is necessary).

On Windows, we had to revert to the old approach which doesn't show progress because KIO::move doesn't work on Windows when crossing partition boundaries. We want to fix this in KIO for a future release. Windows users will have to live without progress for now.

ikloecker changed the task status from Testing to Open.Jun 15 2023, 12:07 PM
ikloecker raised the priority of this task from High to Needs Triage.

Move back to the backlog and trigger re-evalutation of priority (which was high).

ebo moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Jun 15 2023, 12:25 PM

I would give this normal priority still. In guess in most cases its not an issue but when it is an issue it will feel like a bug.