Page MenuHome GnuPG

Kleopatra: Remove "in n days/weeks/months/years" input from Change Validity Period dialog
Closed, ResolvedPublic

Description

Neither the certificate generation dialog nor the certification dialog offer this additional method for specifying the expiration date. The calendar popup of the date combo box allows to add some useful values like "1 year", "2 years", etc., which I think is sufficient.

Nobody wants to extend the lifetime of their certificate for 314 days or 42 weeks or 7 months. :-)
And if somebody wants this, then they can calculate the actual date with Excel or use gpg directly.

Event Timeline

werner added a project: kleopatra.
werner added a subscriber: werner.

I agree.

ikloecker added a project: Restricted Project.
ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
ikloecker changed the task status from Open to Testing.Jul 28 2023, 12:57 PM
ikloecker removed ikloecker as the assignee of this task.
ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.

Done.

I have also further unified the handling of the expiration date when

  • generating a new OpenPGP certificate
  • changing the validity period of an OpenPGP certificate
  • certifying an OpenPGP certificate

This issue should be tested together with T6519: Kleopatra: "change validity" allows to set an expiry date in the past.

Yes I think that can be safely backported to gpg4win/23.07

Especially since it thematically matches our improved expiration date handling in that version.

ebo removed a project: backport.
ebo added a subscriber: ebo.

The choice in the calendar "widget" changed to in 1/2/3 years in all cases. Those options work but the last choice "no date" has no effect.

Tested with VS-Desktop-3.2.0.0-beta214

ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.

I have created a merge request for upstream to remove the useless "No date" option:
https://invent.kde.org/frameworks/kwidgetsaddons/-/merge_requests/213
I have added a patch with the changes to gpg4win, so that we do not have to wait for the fixed upstream version.

The backport wasn't done because the gpg4win/23.07 branch is dead (the summer release was cancelled).

ebo moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Oct 31 2023, 2:11 PM
ebo claimed this task.
ebo moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.

The nonfunctonal "no date" is gone now in VS-Desktop-3.1.90.267-Beta