checked with Gpg4win-4.3.2-beta41:

Selecting a single not suitable certificate and then clicking the "down" button does not result in any action. I do not like it that there is no feedback. But with the changes in T6966 unusable certificates will not be displayed by default, anyway, so I would accept this.

Another thing is that I can select several certificates in which case all the unusable certificated between valid ones can be chosen and and moved to the lower pane. I would judge this to be wrong but not very important.
The group can then be saved, too. And exported (with a warning). I personally would be ok with only the warning despite the task description. But please define somewhere clearly what has been implemented and possibly why the task was changed.

Another thing from the task description was to change the wording ""groups" to "encryption groups" where appropriate.". Where is it appropriate? I do not see any such change.

So now I do not know what to do with this ticket…

The implemented behavior at the moment is:

• certificates that can't be used for encryption are can't be selected in the upper panel and thus not added to the group
• When selecting multiple / all certificates and adding them to the group, the unsuitable certs are not added to the group. This works correctly in qt6 but requires a fix to work in qt5. The fix is part of https://invent.kde.org/pim/kleopatra/-/merge_requests/266 (not yet backported)
• In the groups dialog, groups with unsuitable certs are shown with a warning symbol
• When exporting an invalid group, a warning is shown, but the export is still done. (based on Ingo's suggestion)

The change from "Group" to "Encryption Group" has not been done anywhere.

The Down button should be disabled if no suitable certificates are selected. That may not be the case (in Qt 5) because Qt seems to add disabled rows to the selection and the work around is applied when the Down button is pressed.

Tested with VS-Desktop-3.2.93.33-Beta, where everything necessary is backported:

OK:

• The upper panel has now a default filter only showing usable keys, which does not include expired keys.
• Even If one changes the filter to "all certificates" those unusable are greyed out and can not be selected, not even with the trick to select all certificates.

Maybe OK:

• The warning symbol is only shown if a group contains keys without an encryption key, not if included certificates are expired or revoked.
• If I try to export my test group which already contained an expired and a revoked certificate, I only get a warning that not all certificates are certified exportably.

Is this as we want it?

The Down button should be disabled if no suitable certificates are selected. That may not be the case (in Qt 5)

yes, its not disabled, but as I can't select unusable certificates that's not an issue