Page MenuHome GnuPG
Create Task
Maniphest T6742

Kleopatra: Encryption to group with expired key fails with unexpected message
Closed, ResolvedPublic
Actions

Description

Take a Kleopatra group of OpenPGP Keys from which one is expired and try to encrypt for it:


Selection works with an appropriate feedback, but then the user get an unexpected error message:

If something fails, it should be the encryption, not the Signature....
GpgME seems to "know" the real problem, though:

[7420] org.kde.pim.kleopatra: Kleo::Crypto::SignEncryptTask(0x8f4e648) slotResult job: QGpgME::QGpgMESignEncryptJob(0x62624e0) signing result: "GpgME::SigningResult(\n error:              GpgME::Error(117440565 (Unbrauchbarer öffentlicher Schlüssel))\n createdSignatures:\n invalidSigningKeys:\nGpgME::InvalidSigningKey(\n fingerprint: 1B7724C95351B75394303415C2577F23F8E93418\n reason:      GpgME::Error(117440513 (Allgemeiner Fehler))\n)\n)" encryption result: "GpgME::EncryptionResult(\n error:        GpgME::Error(117440565 (Unbrauchbarer öffentlicher Schlüssel))\n invalid recipients:\nGpgME::InvalidRecipient(\n fingerprint: 1B7724C95351B75394303415C2577F23F8E93418\n reason:      GpgME::Error(117440729 (Alle Unterschlüssel sind abgelaufen oder widerrufen))\n)\n)"

Details

Version
VS-Desktop-3.2.0.0-beta229/231

Revisions and Commits

rLIBKLEO Libkleo
rLIBKLEO36581c3488bb Add two overloads for selecting public certificates with specific usage
rLIBKLEO577f3ba5c333 Add support for certificate groups to icon provider
rLIBKLEO68f9f978f7b2 Indicate validity of groups with bad certificates with error icon
rLIBKLEO0af1c123e7bd Add two overloads for selecting public certificates with specific usage
rLIBKLEO690aeef36dcd Add support for certificate groups to icon provider
rLIBKLEO92d24d493cc5 Indicate validity of groups with bad certificates with error icon
rKLEOPATRA Kleopatra
rKLEOPATRA3be48c4eee10 Report incomplete input if invalid certificates are selected
rKLEOPATRA06182ec9c33e Ensure proper icon for valid certs with invalid encryption subkey
rKLEOPATRA9185715217d1 Also use SignEncryptWidget::isComplete for the notepad
rKLEOPATRA4e3310c17645 Use icon provider for status icon
rKLEOPATRA483f9b35d1f5 Disable Encrypt button of Notepad if invalid recipients are selected
rKLEOPATRA54382219eddd Also use SignEncryptWidget::isComplete for the notepad
rKLEOPATRA1a4ca4ca436c Report incomplete input if invalid certificates are selected
rKLEOPATRAabeca9450550 Ensure proper icon for valid certs with invalid encryption subkey
rKLEOPATRA810e22975f29 Use icon provider for status icon
rKLEOPATRA20fbbb305345 Disable Encrypt button of Notepad if invalid recipients are selected

Related Objects

Event Timeline

• ebo created this task.Oct 2 2023, 10:58 AM
• ebo mentioned this in T6743: Libkleo Keyresolver: check for existing encryption subkey instead valid one, as first step.Oct 2 2023, 11:35 AM
• ebo added a comment.Oct 2 2023, 11:38 AM

This is in contrast to the behavior for "single" keys. An expired key is not listed as available for encryption at all.

• aheinecke added a subscriber: • aheinecke.Oct 5 2023, 9:44 AM

I think that if we know that GnuPG is not encrypting to expired keys we need to use the X icon for that key and disable the sign/encrypt button until this key is removed.

• aheinecke triaged this task as Normal priority.Oct 5 2023, 9:45 AM
• ebo added a comment.Oct 5 2023, 1:05 PM

We decided what aheinecke wrote before: The key group name should be displayed with a red X and the encryption button should be disabled as long as encryption is not possible.

Additionally the details of the group should not (only) be displayed if you click on the symbol (which is very difficult to find) we should add a new, separate info button. Which is also good for a11y.

• ebo added a comment.Oct 5 2023, 1:09 PM

And the filter for the key selection has to be checked. Also compare T6743

• ikloecker claimed this task.Oct 31 2023, 9:41 AM
• ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
• ikloecker added a commit: rLIBKLEO92d24d493cc5: Indicate validity of groups with bad certificates with error icon.Oct 31 2023, 9:57 PM
• ikloecker added a commit: rLIBKLEO690aeef36dcd: Add support for certificate groups to icon provider.
• ikloecker added a commit: rKLEOPATRA20fbbb305345: Disable Encrypt button of Notepad if invalid recipients are selected.Oct 31 2023, 10:01 PM
• ikloecker added a commit: rKLEOPATRA810e22975f29: Use icon provider for status icon.
• ikloecker mentioned this in T6788: Kleopatra: Signing with expired signing subkey shouldn't be possible.Nov 2 2023, 10:46 AM
• ikloecker added a commit: rLIBKLEO0af1c123e7bd: Add two overloads for selecting public certificates with specific usage.Nov 2 2023, 1:56 PM
• ikloecker added a commit: rKLEOPATRAabeca9450550: Ensure proper icon for valid certs with invalid encryption subkey.Nov 2 2023, 2:01 PM
• ikloecker added a commit: rKLEOPATRA1a4ca4ca436c: Report incomplete input if invalid certificates are selected.
• ikloecker added a commit: rKLEOPATRA54382219eddd: Also use SignEncryptWidget::isComplete for the notepad.
• ikloecker changed the task status from Open to Testing.Nov 2 2023, 2:09 PM
• ikloecker removed • ikloecker as the assignee of this task.
• ikloecker added a subscriber: • ikloecker.

Fixed for Sign/Encrypt Files/Folders and Sign/Encrypt notepad.

  • Invalid encryption certificates and groups with invalid encryption certificates are now marked with the red error icon.
  • The Sign/Encrypt button is disabled if invalid encryption certificates/groups have been selected.
  • Works for both: The encrypt to self certificate and the encrypt to others certificates/groups.
  • Works for groups containing invalid encryption certificates and for valid certificates with invalid encryption subkeys.

Note: Similar issues with invalid signing certificates have been fixed for T6788: Kleopatra: Signing with expired signing subkey shouldn't be possible.

• aheinecke added a project: vsd32.Nov 10 2023, 4:21 PM

Discussed this with ebo. This is a bugfix that should be in the release even though it is multiple changes I will cherry pick them over to the release branches.

• aheinecke added a commit: rLIBKLEO68f9f978f7b2: Indicate validity of groups with bad certificates with error icon.Nov 10 2023, 5:13 PM
• aheinecke added a commit: rLIBKLEO36581c3488bb: Add two overloads for selecting public certificates with specific usage.
• aheinecke added a commit: rLIBKLEO577f3ba5c333: Add support for certificate groups to icon provider.
• aheinecke added a commit: rKLEOPATRA483f9b35d1f5: Disable Encrypt button of Notepad if invalid recipients are selected.
• aheinecke added a commit: rKLEOPATRA4e3310c17645: Use icon provider for status icon.
• aheinecke added a commit: rKLEOPATRA06182ec9c33e: Ensure proper icon for valid certs with invalid encryption subkey.
• aheinecke added a commit: rKLEOPATRA9185715217d1: Also use SignEncryptWidget::isComplete for the notepad.
• aheinecke added a commit: rKLEOPATRA3be48c4eee10: Report incomplete input if invalid certificates are selected.
• aheinecke moved this task from Backlog to QA on the vsd32 board.Nov 10 2023, 7:02 PM
• ebo added a comment.Nov 14 2023, 11:16 AM

Works for the reported and important cases, Tested with VS-Desktop-3.1.90.277-Beta

For the case from the description, a group with one expired key it looks now like this:


Debugview only says the same:
[7124] org.kde.pim.kleopatra: Setting KeyGroup. "OpenPGP (2 Schlüssel, nicht alle beglaubigt)"

I do not really like the text "not all certified" as it is misleading. "Not all valid would" be better. What do you say? For me it looks like a no-brainer but I don't now where else the same code is used where the phrasing maybe doesn't fit.

But I like very much that clicking on the red X brings up the group details where I can see that one key is expired. Now that I know this feature exists.
What about the second part of https://dev.gnupg.org/T6742#176528? Should I make a separate a11y ticket for that with low prio?

For a valid, but not VS-NfD compliant key it looks like this and encryption is possible:

If a valid key has only an expired encryption subkey it looks like this:


Here we could discuss, too, if we want a new ticket with a low prio for this or we want to leave it.

• ikloecker added a comment.Nov 14 2023, 2:16 PM

What about the second part of https://dev.gnupg.org/T6742#176528? Should I make a separate a11y ticket for that with low prio?

Yes.

• ebo mentioned this in T6819: Kleopatra: Add separate info button for group info to improve accessibility .Nov 14 2023, 4:09 PM
• ebo closed this task as Resolved.Nov 14 2023, 4:15 PM
• ebo claimed this task.
• ebo moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.

ok, opened T6819 for the separate button.
The rest is ok, I think. As long as we display keypairs in a single entry, it can not be helped that they may appear valid in the certificate list but are invalid for signing or encryption subkeys.
We display that here correct for the respective contexts.
Therefore closing,

• ebo moved this task from QA to vsd-3.2.0 on the vsd32 board.Nov 14 2023, 4:16 PM
• ebo edited projects, added vsd32 (vsd-3.2.0); removed vsd32.