GpgOL: RSA 2048 Key generated in VSD
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• ebo
	Nov 9 2023, 1:58 PM

Description

Noticed when testing T6683:
After acknowledging the new "No X509 certificate found" window and choosing in the next window -> OpenPGP -> Generate, a "generate key, this may take a while"- window appears and does not go away (at least not in the usual time...) although in the background the newly generated key is listed in the certificate list in Kleopatra.
After hitting cancel on 2 windows checking the details of the generated key show that it is RSA 2048.
But it is shown as VS-NfD compliant anyway.

When trying to send a signed mail the next time, this certificate is used and accepted as compliant.

Details

Version: VS-Desktop-3.1.90.267-Beta

Revisions and Commits

rLIBKLEO Libkleo
	rLIBKLEO66cd41861f31 Use QuickJob instead of DefaultKeyGenerationJob for generating key
	rLIBKLEOd2c86206efe9 Use QuickJob instead of DefaultKeyGenerationJob for generating key
	rLIBKLEO776d4d634f1e Deprecate DefaultKeyGenerationJob
rM GPGME
	rM52d59d75cae5 qt: Deprecate DefaultKeyGenerationJob

Related Objects

Mentioned In: T6813: GpgOL: Key generation window does not close
T6683: GpgOL: Configurable error if sign is selected and prefer_smime
T6685: QGpgME: Update defaultkeygenerationjob and use create-key API
Mentioned Here: T6813: GpgOL: Key generation window does not close
T6566: GpgOL: newly generated key not loaded in the security confirmation dialog
T6685: QGpgME: Update defaultkeygenerationjob and use create-key API
T6683: GpgOL: Configurable error if sign is selected and prefer_smime

Event Timeline

• ebo triaged this task as High priority.Nov 9 2023, 1:58 PM

• ebo created this task.

We consider rsa2048 as compliant until the end of this year; this is required due to the Telesec smartcards. However, we should never create such a key and kleopatra does not allow this.

• werner added a project: gpgol.Nov 9 2023, 2:21 PM

This is an incarnation of T6685 while we decided to deprecate that job we did not open a ticket to do it and forgot about it. So we did not notice that it was still used in the keyapprovaldialog. Fix is to replace it there with the correct key generation job.

libkleo/src/ui/newkeyapprovaldialog.cpp

• aheinecke mentioned this in T6685: QGpgME: Update defaultkeygenerationjob and use create-key API.Nov 9 2023, 2:54 PM

• ebo mentioned this in T6683: GpgOL: Configurable error if sign is selected and prefer_smime .Nov 9 2023, 3:46 PM

See https://dev.gnupg.org/T6685#174802

ikloecker added a project: gpgme.Nov 10 2023, 8:53 AM

ikloecker added a commit: rM52d59d75cae5: qt: Deprecate DefaultKeyGenerationJob.Nov 10 2023, 9:52 AM

ikloecker added a commit: rLIBKLEO776d4d634f1e: Deprecate DefaultKeyGenerationJob.Nov 10 2023, 2:22 PM

ikloecker added a commit: rLIBKLEOd2c86206efe9: Use QuickJob instead of DefaultKeyGenerationJob for generating key.

We are now generating a key with whatever defaults gpg uses.

That sounds very good.

• aheinecke added a commit: rLIBKLEO66cd41861f31: Use QuickJob instead of DefaultKeyGenerationJob for generating key.Nov 10 2023, 5:13 PM

• aheinecke moved this task from WiP to QA on the vsd32 board.Nov 10 2023, 7:02 PM

• aheinecke moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Nov 13 2023, 9:12 AM

With VS-Desktop-3.1.90.277-Beta the generated key is the default RSA 3072.

But the part with the "key generation" window not closing remains. I aborted the "key generation" (which at this point was long done) after 5 minutes. Do you want a new ticket for that or do we continue here?

No it is just not properly selected after generation but it is there. I think there might even be an issue for that already. But definitely not something related to vsd 3.2

The issue for that is: https://dev.gnupg.org/T6566 so I think this can be resolved here?

After reading the initial description of this, I think that might even be a yet a different bug. For which we then would not yet have a ticket. :)

Ok closing, remaining issue is in T6813

• ebo moved this task from QA to vsd-3.2.0 on the vsd32 board.Nov 13 2023, 12:27 PM

• ebo edited projects, added vsd32 (vsd-3.2.0); removed vsd32.

• ebo moved this task from Backlog to gpgme 1.23.x on the gpgme board.

• ebo edited projects, added gpgme (gpgme 1.23.x); removed gpgme.

• ebo moved this task from gpgme 1.23.x to QA for next release on the gpgme board.

• ebo edited projects, added gpgme; removed gpgme (gpgme 1.23.x).