GpgOL: newly generated key not loaded in the security confirmation dialog
Closed, ResolvedPublic

Assigned To
Authored By
• ebo
Jun 29 2023, 11:23 AM
Tags

Description

When you generate your keypair via GpgOL, the newly generated keys are not loaded in the security confirmation dialog:

You can choose the newly generated key for both input fields, though:

Although this is a working workaround the most obvious thing for a user to do is hit "generate key" again, as it didn't seem to work. And thereby generate a second key, which again will not be shown without opening the dropdown.

Expected behavior: The newly generated key is immediately shown in both fields and the action button changes from "Generate" to "OK".

Details

Version
3.1.26, Gpg4win-4.2.0-beta357

Event Timeline

• aheinecke added a subscriber: • aheinecke.

I noticed this recently, too. Should be fixed. Especially if we want to use this in KMail, too.

• aheinecke added a project: vsd32.
• aheinecke added a subscriber: • ikloecker.

This can be also reproduced easily on Linux with test_keyresolver from libkleo:

GNUPGHOME=$(mktemp -d) ./test_keyresolver --sender foo@bar.baz foo@bar.baz

@ikloecker Can you maybe take a look at this. I think that should be a pretty easy fix for you and I would backport this to vsd32 if there is no regression risk. (Which would surprise me)

• ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Nov 16 2023, 8:26 AM
• ikloecker moved this task from Backlog to WiP on the vsd32 board.

Fixed with the above two commits.

I noticed some other weirdness that doesn't seem to cause problems but that should anyway be fixed but only for the next release.

• ikloecker changed the task status from Open to Testing.Nov 16 2023, 1:23 PM

Merci vielmals. Cherry-picked.

VS-Desktop-3.1.90.287-Beta

Seems T6813 blocks me from testing this. The generate window does not close and even if I abort the window, the generated key is not loaded. It is not selectable even if I remove the filter.

works, VS-Desktop-3.1.90.295-Beta

• ebo edited projects, added vsd32 (vsd-3.2.0); removed vsd32.
• werner moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Sep 26 2024, 3:14 PM
• werner claimed this task.
• werner added a subscriber: • werner.

Should definitely work with gpg4win if it works with vsd.