Maniphest T6864

GpgOL: Invalid filenames are not checked for temporary files
Closed, ResolvedPublic
Actions

Assigned To
• aheinecke
Authored By
• aheinecke
Dec 4 2023, 11:10 AM
Tags
Subscribers
• aheinecke
mmontkowski

Description

One of the first thing I tested with Mimetreeparser was to open an attached mail and got a failure due to invalid path. I think we don't have an issue for that. But T6760 fixed it.

Turns out I have exactly the same problem in GpgOL forever. Where attachments with invalid file names could not be opened.

Revisions and Commits

rO GpgOL
rOdbcfa2b2f8bd Add filename sanitizers for windows filenames

Related Objects

Event Timeline

• aheinecke triaged this task as Normal priority.Dec 4 2023, 11:10 AM
• aheinecke created this task.
mmontkowski moved this task from Backlog to WiP on the vsd33 board.May 23 2024, 3:01 PM
• aheinecke added a commit: rOdbcfa2b2f8bd: Add filename sanitizers for windows filenames.Aug 23 2024, 1:22 PM
• werner mentioned this in Unknown Object (Maniphest Task).Aug 28 2024, 11:51 AM
• ebo changed the task status from Open to Testing.Aug 28 2024, 11:58 AM
• ebo added a project: vsd32 (vsd-3.2.3).
• ebo moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
mmontkowski closed this task as Resolved.Aug 28 2024, 4:33 PM
mmontkowski added a subscriber: mmontkowski.

Works fine.
For special DOS names only COM/LPT1-9 are supported names like COM12 are not handled.
But that is not really an issue as these names are always prepended with the temp-pathname and c:\tmp\COM12 are valid names.

mmontkowski mentioned this in T4835: attachement not displayed when pipe in filename of attachement.Aug 28 2024, 4:34 PM
mmontkowski moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Aug 28 2024, 4:37 PM
• ebo moved this task from WiP to vsd-3.3.0 on the vsd33 board.Feb 28 2025, 10:52 AM
• ebo edited projects, added vsd33 (vsd-3.3.0); removed vsd33.
mmontkowski mentioned this in T7813: GpgOL: Message "Not all attachments can be shown, exceeds maximum size" incorrectly shown.Sep 15 2025, 11:47 AM
• ebo moved this task from Backlog to Done on the gpgol board.Nov 17 2025, 9:04 AM