Page MenuHome GnuPG

don't use deprecated grep aliases
Closed, ResolvedPublic

Description

libgcrypt-config.in includes usage of fgrep, which is deprecated and prints a warning. see https://www.shellcheck.net/wiki/SC2196

for details.

this patch seems to be working fine:

--- libgcrypt-1.10.3.orig/src/libgcrypt-config.in
+++ libgcrypt-1.10.3/src/libgcrypt-config.in
@@ -154,7 +154,7 @@ if test "$echo_cflags" = "yes"; then

     tmp=""
     for i in $includes $cflags_final; do
-       if echo "$tmp" | fgrep -v -- "$i" >/dev/null; then
+       if echo "$tmp" | @GREP@ -F -v -- "$i" >/dev/null; then
            tmp="$tmp $i"
        fi
     done
@@ -175,7 +175,7 @@ if test "$echo_libs" = "yes"; then

     tmp=""
     for i in $libdirs $libs_final; do
-       if echo "$tmp" | fgrep -v -- "$i" >/dev/null; then
+       if echo "$tmp" | @GREP@ -F -v -- "$i" >/dev/null; then
            tmp="$tmp $i"
        fi
     done

Event Timeline

dirkmueller created this object in space S1 Public.
dirkmueller updated the task description. (Show Details)
dirkmueller updated the task description. (Show Details)
dirkmueller added a project: libgcrypt.
gniibe added a subscriber: gniibe.

Thank you. I recently fixed for use of egrep rC656ca459e3d8: m4: Update acinclude.m4 to use $GREP., but overlooked this one.

I'll apply the change.

Please note that libgcrypt-config script will not be installed any more in next version of libgcrypt, in preference of use of gpgrt-config with libgcrypt.pc.

gniibe changed the task status from Open to Testing.Jan 29 2024, 2:54 AM
gniibe triaged this task as Normal priority.