Page MenuHome GnuPG

Kleopatra: Create an appearance filter for the "disabled" status
Closed, ResolvedPublic

Description

Edit 2024-11-8: It was agreed that the filter is now obsolete. But removal will be done with T6666

Edit 2024-07-31: It was decided to at first only create an appearance filter for disabled certificates. People can then at least mark the disabled certificates in a uniform way.

Is should be possible to hide all "disabled" certificates from view in the certificate list

A toggle button to show/hide "disabled certificates" would be good. In this way it could be combined with all other filters.

In the UI it could replace the "shield" button next to the drop down filters which only triggers the "not certified certificates" filter and is therefore redundant.
But the "don't show disabled certificates" button should have another symbol and one should see whether it is toggled on or off.

Event Timeline

ebo triaged this task as Normal priority.Jul 24 2024, 10:26 AM
ebo raised the priority of this task from Normal to Needs Triage.
ebo created this task.

Let's not make the filtering more complex. It's already complex enough with the search field and the filter drop down. If we want more flexible filtering then this should be solved in a general way and not as Sonderlocke for "disabled". "disabled" is really a niche feature and, in my opinion, doesn't deserve a prominent UI element in the main UI.

aheinecke claimed this task.
aheinecke added a subscriber: aheinecke.

I fully agree with ingo.

Comment edited. We still might want to have that discussion about what we should aim for but this ticket is not the correct place for it. Apologies.

ebo renamed this task from Draft: Kleopatra: Allow filtering by "disabled" status to Kleopatra: Create an appearance filter for the "disabled" status.Jul 31 2024, 4:04 PM
ebo reopened this task as Open.
ebo reassigned this task from aheinecke to TobiasFella.
ebo triaged this task as Normal priority.
ebo updated the task description. (Show Details)
ebo added a project: vsd33.
TobiasFella moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Aug 1 2024, 11:37 AM
TobiasFella set External Link to https://invent.kde.org/pim/libkleo/-/merge_requests/123.
TobiasFella changed the task status from Open to Testing.Aug 5 2024, 11:40 AM

Backported for VSD 3.3

ebo moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Oct 1 2024, 3:55 PM

Gpg4win-Beta-70:
There is an appearance filter for disabled certificates now.
Though I wonder if it is really necessary / useful, as we now have regular filters, too. I would have thought we only need the regular filters. I think the appearance filter was to be a stopgap as we did not want to touch the filters at the time when this ticket was created.
What do you say?

I agree that it doesn't make sense anymore because we never show disabled and not-disabled certificates next to each other.

Agree with removing the appearance filter

ebo changed the task status from Testing to Open.Nov 8 2024, 10:29 AM
ebo updated the task description. (Show Details)

Testing the removal of the appearance flag from this filter leads to this situation:

  • The filter is still shown in the configuration UI for filter appearance (Settings -> Configure Kleopatra -> Appearance -> Certificate Categories), as this list doesn't evaluate whether the filter is actually an appearance filter
  • The filter is no longer used for calculating the appearance of certificates in the list (as expected)

This leads to an unexpected mismatch between configuration and appearance. The proper fix would be for the configuration list to only show appearance filters, but that might be a bigger change than we want to introduce at this point in the release cycle.

Since it doesn't really hurt us to have it also as an appearance filter, I'd propose to keep it as-is for now and look into larger changes when doing the larger filter changes we want to do

ebo moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.

Ok with me. setting this to resolved, then.