Page MenuHome GnuPG
Create Task
Maniphest T7230

pinentry-qt: Show passphrase icon nearly invisible in dark mode and high contrast
Closed, ResolvedPublic
Actions

Description

In dark mode or in the dark high contrast modes the icon to reveal the passphrase is close to invisible.

High contrast mode in Windows 10:

Revisions and Commits

rP Pinentry
rPf4be34f83fd2 qt: Add dark mode icon variants and detection

Related Objects

Event Timeline

• aheinecke triaged this task as Normal priority.Jul 30 2024, 8:10 PM
• aheinecke created this task.
• aheinecke closed this task as Resolved.Jul 30 2024, 10:26 PM
• aheinecke claimed this task.

Tested on Linux, modern Windows and Windows 10 2016.

I was curious to test if this all worked by using the new Qt6 dark mode query:

/* Check for dark scheme to determine the icons */
#if QT_VERSION >= QT_VERSION_CHECK(6, 5, 0)
    QStyleHints *styleHints = qApp->styleHints();
    if (styleHints && styleHints->colorScheme() == Qt::ColorScheme::Dark) {
        mIconSuffix = QStringLiteral("_dark");
    }
#endif

And it worked in the high contrast and dark mode scenarios.

• aheinecke mentioned this in T6932: Icons, darkmode and stuff.Jul 30 2024, 10:28 PM
• aheinecke added a commit: rPf4be34f83fd2: qt: Add dark mode icon variants and detection.Jul 30 2024, 11:39 PM