Page MenuHome GnuPG
Create Task
Maniphest T7301

Kleopatra: Remove any usage and mention of the short Key ID
Testing, LowPublic
Actions

Description

While checking the support of V5 fingerprints in Kleopatra (T7297) I noticed that the short Key ID is very awkward for V5 keys because the short Key ID is the last 4 octets of the 8 octet Key ID and the 8 octet Key ID is the first 8 octets of the V5 fingerprint. So, unlike for V4 keys the short Key ID is neither the first nor the last 4 octets of the V5 fingerprint but some octets "somewhere in the middle" of the V5 fingerprint.

Since the short Key ID is anyway a dangerous anachronism we should remove its usage anywhere in Kleopatra (e.g. we use it for the filenames of exported keys).

Revisions and Commits

rLIBKLEO Libkleo
rLIBKLEOd798751e6844 Remove ShortKeyID column from key list model
rLIBKLEO93f0c1475550 Show key ID instead of short key ID in short key info
rLIBKLEObe41848b9b22 Show key ID instead of short key ID in tool tip if KeyID is requested
rLIBKLEO8183ed5c4487 Show key ID instead of short key ID in KeySelectionDialog
rLIBKLEO669f35f0f1a3 Show key ID instead of short key ID in KeyRequester
rLIBKLEOdc9f7238dd02 Remove obsolete lookup of keys by short (4 octet) key ID
rKLEOPATRA Kleopatra
rKLEOPATRA64d2062471f1 Use the key ID instead of the short key ID for filenames
rKLEOPATRA86f38c93b9ac Remove unneeded lookup of key by short (4 octet) key ID

Related Objects

Event Timeline

• ikloecker created this task.Wed, Sep 25, 11:48 AM
• werner triaged this task as Low priority.Wed, Sep 25, 3:31 PM
• werner added a subscriber: • werner.

Yes, this is a bit annoying but recall that for v3 keys you can't even deduce the keyid from its fingerprint.

In a GUI you can c+p stuff and thus the keyid is not very useful anyway. I don't see a problem with the filenames but I have no problem if you change the name to the full fingerprint. (But please also replace spaces by underscores).

• ikloecker added a commit: rKLEOPATRA86f38c93b9ac: Remove unneeded lookup of key by short (4 octet) key ID.Wed, Sep 25, 4:18 PM
• ikloecker claimed this task.Wed, Sep 25, 4:46 PM
• ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
• ikloecker added a commit: rLIBKLEOdc9f7238dd02: Remove obsolete lookup of keys by short (4 octet) key ID.Thu, Sep 26, 3:06 PM
• ikloecker added a commit: rLIBKLEO669f35f0f1a3: Show key ID instead of short key ID in KeyRequester.
• ikloecker added a commit: rLIBKLEO8183ed5c4487: Show key ID instead of short key ID in KeySelectionDialog.
• ikloecker added a commit: rLIBKLEObe41848b9b22: Show key ID instead of short key ID in tool tip if KeyID is requested.
• ikloecker added a commit: rLIBKLEO93f0c1475550: Show key ID instead of short key ID in short key info.
• ikloecker added a commit: rLIBKLEOd798751e6844: Remove ShortKeyID column from key list model.
• ikloecker added a commit: rKLEOPATRA64d2062471f1: Use the key ID instead of the short key ID for filenames.Thu, Sep 26, 3:32 PM
• ikloecker changed the task status from Open to Testing.Thu, Sep 26, 4:32 PM

Done. I don't think this needs to be tested extensively because it's just some UI texts that now show the Key ID (with 16 hex chars) instead of the short Key ID (8 hex chars). And for files including key material we also use the Key ID (of primary key and/or subkey) now for the filenames, e.g. when exporting a public/secret key/subkey.

The most visible changes are in UI components that are only used by KMail (and other apps using the messagecomposer functionality).