Page MenuHome GnuPG
Create Task
Maniphest T7331

Kleopatra: Improvements for debug dialog
Testing, NormalPublic
Actions

Description

  • Allow typing custom commands into the combobox (with config option for disabling this)
  • Allow defining commands from a config file

Revisions and Commits

rLIBKLEO Libkleo
rLIBKLEO1f1fac569c2d Add debug commands to libkleopatrarc
rKLEOPATRA Kleopatra
rKLEOPATRA7cb2e48844fa Make sure debug dialog commands are run only once when pressing Enter
rKLEOPATRA1bd603d0dd24 Make sure debug dialog commands are run only once when pressing Enter
rKLEOPATRAdd308e814d1d Fix crash in debug dialog
rKLEOPATRA0ae32b1f49db Close standard input for debug commands
rKLEOPATRAd015867d664e Make sure debug dialog commands are run only once when pressing Enter
rKLEOPATRAde346048d83a Fix crash in debug dialog
rKLEOPATRA79c20b6207ac Close standard input for debug commands
rKLEOPATRA7f96ad9fc189 Close standard input for debug commands
rKLEOPATRA86a3a62a36a9 Fix crash in debug dialog
rKLEOPATRAa10861389dab Improve debug dialog
rKLEOPATRAd86ff68b3d51 Improve debug dialog
rKLEOPATRA3a441b4abced Improve debug dialog
rKLEOPATRA7b3dbad0aee7 Improve debug dialog
rKLEOPATRA056442aada3a Improve debug dialog
rKLEOPATRA330efa5b8951 Improve debug dialog
rKLEOPATRAe9a6c30198a5 Improve debug dialog
rKLEOPATRAe3ff6cf89ec1 Improve debug dialog
rW Gpg4win
rWe054fefd50d0 Install configuration file for kleopatra debug commands

Related Objects

Event Timeline

• TobiasFella triaged this task as Normal priority.Oct 10 2024, 10:05 AM
• TobiasFella created this task.
• TobiasFella added a commit: rKLEOPATRAe3ff6cf89ec1: Improve debug dialog.Oct 10 2024, 2:44 PM
• TobiasFella added a commit: rKLEOPATRAe9a6c30198a5: Improve debug dialog.Oct 11 2024, 12:33 PM
• TobiasFella added a commit: rKLEOPATRA330efa5b8951: Improve debug dialog.Oct 15 2024, 2:45 PM
• TobiasFella added a commit: rLIBKLEO1f1fac569c2d: Add debug commands to libkleopatrarc.Oct 15 2024, 2:48 PM
• TobiasFella added a commit: rKLEOPATRA056442aada3a: Improve debug dialog.Oct 16 2024, 1:59 PM
• ebo added a subscriber: • ebo.Oct 16 2024, 4:39 PM

This is related to T6072: Kleopatra: Display "gpgconf -X"

• TobiasFella removed a project: gpd5x.Oct 16 2024, 4:42 PM
• ebo added a project: Restricted Project.Oct 16 2024, 4:43 PM
• TobiasFella added a commit: rKLEOPATRA7b3dbad0aee7: Improve debug dialog.Oct 16 2024, 4:53 PM
• TobiasFella added a commit: rKLEOPATRA3a441b4abced: Improve debug dialog.Oct 17 2024, 10:43 AM
• TobiasFella added a commit: rKLEOPATRAd86ff68b3d51: Improve debug dialog.Oct 17 2024, 2:54 PM
• TobiasFella moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Oct 17 2024, 2:55 PM
• TobiasFella added a comment.Oct 17 2024, 3:00 PM

Implemented in https://invent.kde.org/pim/kleopatra/-/merge_requests/290

Some notes:

  • The config key for disabling custom commands is AllowCustomDebugCommands under General in kleopatrarc (default true)
  • Commands can be defined in kleopatradebugcommandsrc; the format is explained in debugdialog.cpp
  • Custom commands are appended to the list of the combobox (but will be gone after closing the dialog)
  • To work in gpg4win, a change for the build scripts is needed to install kleopatradebugcommandsrc (similar to what it's doing for libkleopatrarc). I'll try to get to it today, but if i don't, it would be best if someone else takes care of that before i'm back
• ikloecker added a project: kleopatra.Oct 28 2024, 1:30 PM
• ikloecker added a commit: rKLEOPATRAa10861389dab: Improve debug dialog.Oct 28 2024, 1:50 PM
• ikloecker moved this task from Backlog to WiP on the vsd33 board.Oct 28 2024, 1:51 PM
• ikloecker added a subscriber: • ikloecker.

Backported for vsd33

• werner added a subscriber: • werner.Mon, Nov 4, 11:41 AM

Applied Tobias installation patch to gpg4win master (vsd33)

• ebo changed the task status from Open to Testing.Mon, Nov 4, 11:46 AM
• werner added a commit: rWe054fefd50d0: Install configuration file for kleopatra debug commands.Mon, Nov 4, 11:52 AM
• ebo moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Fri, Nov 8, 2:09 PM
• ebo changed the task status from Testing to Open.Mon, Nov 11, 2:35 PM
• ebo moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.

Gpg4win-Beta-75: This is in principle ok. Even adding further commands to
C:\Program Files (x86)\Gpg4win\etc\xdg\kleopatradebugcommandsrc works:

But:
When I enter "gpg" + Return in the Input field, 2 gpg processes are started and no output is shown in the output field of the window.
Closing the window is then followed by a crash:

5484	18119.858606	6460	kleopatra.exe	QProcess: Destroyed while process ("gpg") is still running.
5485	18122.194077	6460	kleopatra.exe	<process started at 14:25:44.877 has terminated with 0xc0000005 (EXCEPTION_ACCESS_VIOLATION)>
• ikloecker added a comment.Mon, Nov 11, 3:01 PM

The QProcesses we start should be configured with closed stdin so that the started process don't hang waiting for input, e.g. by calling closeWriteChannel() immediately after start(). Or by calling start() with QIODeviceBase::ReadOnly, but, sadly, the documentation of QProcess doesn't document what effect that has.

Hmm, calling QProcess::setStandardInputFile(QProcess::nullDevice()) before start() may be even better than calling closeWriteChannel() after start().

• TobiasFella added a commit: rKLEOPATRA86a3a62a36a9: Fix crash in debug dialog.Mon, Nov 11, 3:33 PM
• TobiasFella added a comment.Mon, Nov 11, 3:34 PM

Fix for the crash https://invent.kde.org/pim/kleopatra/-/merge_requests/318

• TobiasFella added a commit: rKLEOPATRA7f96ad9fc189: Close standard input for debug commands.Mon, Nov 11, 3:46 PM
• TobiasFella added a comment.Mon, Nov 11, 3:46 PM

Hmm, calling QProcess::setStandardInputFile(QProcess::nullDevice()) before start() may be even better than calling closeWriteChannel() after start().

Done in https://invent.kde.org/pim/kleopatra/-/merge_requests/319

• TobiasFella added a commit: rKLEOPATRA79c20b6207ac: Close standard input for debug commands.Tue, Nov 12, 9:40 AM
• TobiasFella added a commit: rKLEOPATRAde346048d83a: Fix crash in debug dialog.Tue, Nov 12, 9:48 AM
• TobiasFella added a commit: rKLEOPATRAd015867d664e: Make sure debug dialog commands are run only once when pressing Enter.Tue, Nov 12, 10:39 AM
• TobiasFella added a comment.Tue, Nov 12, 10:40 AM

And to make commands run only once when Enter is pressed: https://invent.kde.org/pim/kleopatra/-/merge_requests/320

• ikloecker added a commit: rKLEOPATRA0ae32b1f49db: Close standard input for debug commands.Tue, Nov 12, 1:24 PM
• ikloecker added a commit: rKLEOPATRAdd308e814d1d: Fix crash in debug dialog.
• TobiasFella added a commit: rKLEOPATRA1bd603d0dd24: Make sure debug dialog commands are run only once when pressing Enter.Wed, Nov 13, 10:14 AM
• ikloecker mentioned this in T7395: Prepare Release Notes for Gpg4win 4.4.0 for Kleopatra.Wed, Nov 13, 5:04 PM
• ikloecker added a commit: rKLEOPATRA7cb2e48844fa: Make sure debug dialog commands are run only once when pressing Enter.Wed, Nov 13, 5:21 PM
• ikloecker added a comment.Wed, Nov 13, 5:23 PM

All changes have been backported for VSD 3.3

• ikloecker changed the task status from Open to Testing.Wed, Nov 13, 5:24 PM
• ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.

I guess it's now ready for testing

• ebo moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Tue, Nov 26, 12:26 PM

Gpg4win-Beta-94: works.

Could be a bit more refined in the future, but this would be for another ticket.