pinentry: Add `--focus=ok` option to `CONFIRM` command
Open, NormalPublic

Assigned To
Authored By
gniibe
Tue, Jun 30, 8:35 AM

Description

For T8182 and T2265, for CONFIRM command, it's good to enhance the pinentry implementations to explicitly recognize which is default.

My plan is adding --focus=ok and --focus=cancel option.

We now have mostly unused field in struct pinentry: confirm
This field could be re-used to have -1 for cancel, 1 for ok, 0 for implementation dependent.

Edit: default is already used to specify the string, so, use the word focus

Event Timeline

gniibe triaged this task as Normal priority.Tue, Jun 30, 8:35 AM
gniibe created this task.
gniibe renamed this task from pinentry: Add `--default=ok` option to `CONFIRM` command to pinentry: Add `--focus=ok` option to `CONFIRM` command.Wed, Jul 1, 6:38 AM
gniibe updated the task description. (Show Details)

Done for: Curses and GTK+2
(My commit message for GTK+2 change was wrongly described as curses, though. sorry)

Sorry again for wrong short description of the commit message. The commit of rPd63023151d25: Support confirm_focus in pinentry-qt/qt4/qt5/tqt. is for Windows.

For FLTK, we have to change the order (it doesn't support specifying the default, but option 1 is the default):
https://www.fltk.org/doc-1.4/group__group__comdlg.html