qt,qt5: Install and use pinentry icon
ClosedPublic
Actions

Authored by • TobiasFella on Mar 28 2024, 2:29 PM.

Details

Reviewers

• ikloecker
• werner

Summary

See T7065: pinentry 1.3.0 ships desktop file with icons, but does not install them

Test Plan

Install && check icon exists

Diff Detail

Repository

rP Pinentry

Lint

Lint Skipped

Unit

Unit Tests Skipped

Event Timeline

• TobiasFella requested review of this revision.Mar 28 2024, 2:29 PM

• TobiasFella created this revision.

I'm wondering whether it wouldn't be better to rename (or copy) the icon to pinentry.png. It's weird if a program installs an icon with a generic name in a generic location.

I suggest: Rename (or copy if we need the icon with the original name) the icon to pinentry.png. The rest looks okay for now.

• ikloecker requested changes to this revision.Apr 8 2024, 10:19 AM

This revision now requires changes to proceed.Apr 8 2024, 10:19 AM

• TobiasFella updated this revision to Diff 1616.Apr 8 2024, 3:18 PM

• TobiasFella retitled this revision from qt,qt5: Install document-encrypt icon for desktop file to qt,qt5: Install and use pinentry icon.

• TobiasFella edited the summary of this revision. (Show Details)

Looks good

This revision is now accepted and ready to land.Apr 8 2024, 5:03 PM

• TobiasFella closed this revision.Apr 9 2024, 10:21 AM

Revision Contents
Changeset List

Path

Size

qt/

icons/

Makefile.am

3 lines

qt5/

icons/

Makefile.am

3 lines

Diff 1615

View Options

qt/icons/Makefile.am