Page MenuHome GnuPG
Feed Advanced Search

Oct 25 2017

jiazhang added a comment to T3454: Hash SM3 support.

CESI also publishes a complete white pager documenting OID assignment in details. See http://www.cesi.cn/201612/1688.html and download the pdf. Search "10197" and I see the following info:

Oct 25 2017, 4:14 AM · libgcrypt, Feature Request

Oct 24 2017

jiazhang added a comment to D449: [PATCH] sm3: implement SM3 hash algorithm.

Thanks for your great help! Once merged, I will continue the contributions to coreutils and gnulib in order to make sm3sum program eventually available.

Oct 24 2017, 8:48 AM
jiazhang updated the diff for D449: [PATCH] sm3: implement SM3 hash algorithm.

V2 Changelog:

Oct 24 2017, 8:19 AM
jiazhang added a comment to D449: [PATCH] sm3: implement SM3 hash algorithm.
Oct 24 2017, 8:18 AM
jiazhang added a comment to D449: [PATCH] sm3: implement SM3 hash algorithm.
In D449#3605, @gniibe wrote:

Thanks for your quick response.

It's good that we have the OID already.
I read the Chinese document briefly, I realized that its basically equivalent to the IETF draft.

Please update your sm.c so that it includes Example 2 in the document.
Then, I will merge the code into the master of libgcrypt git repo.

After that, I will add the code for OID, examining its status. Does it work for you?

Oct 24 2017, 7:47 AM
jiazhang added a comment to D449: [PATCH] sm3: implement SM3 hash algorithm.
In D449#3606, @gniibe wrote:

IIUC, it's defined by the agency in 2010, and then it was published as the national standard: GM/T 0004-2012 SM3密码杂凑算法

Oct 24 2017, 7:47 AM
jiazhang added a comment to D449: [PATCH] sm3: implement SM3 hash algorithm.
In D449#3603, @gniibe wrote:

For the implementation, it looks good for me.
I have suggestions and some requests.

Suggestions:

  • I think that the all test vectors in draft-shen-sm3-hash should be in sm3.c.

    If I read your code correctly, the "abc" in Example 1 is there. I think that the vector in Example 2 in the document should be also provided.
Oct 24 2017, 4:32 AM

Oct 17 2017

jiazhang updated the diff for D449: [PATCH] sm3: implement SM3 hash algorithm.

This is the updated patch with sm3.c. The others are not touched.

Oct 17 2017, 11:36 AM
jiazhang added a comment to T3454: Hash SM3 support.

This is my note.
If it is intended to be used to OpenPGP, GCRY_MD_SM3 should be assigned in OpenPGP standard.

Oct 17 2017, 4:57 AM · libgcrypt, Feature Request
jiazhang added a comment to T3454: Hash SM3 support.

Thank you. The diff doesn't include sm3.c. Could you please update?

Oct 17 2017, 4:52 AM · libgcrypt, Feature Request
jiazhang added a comment to T3454: Hash SM3 support.

This is the review request link: https://dev.gnupg.org/D449

Oct 17 2017, 4:45 AM · libgcrypt, Feature Request
jiazhang created D449: [PATCH] sm3: implement SM3 hash algorithm.
Oct 17 2017, 4:12 AM