User Details
- User Since
- Mar 27 2017, 4:47 PM (393 w, 6 d)
- Availability
- Available
Nov 20 2014
Hello werner, a gentle reminder for this bug, have a look, if possible, it has
been over 3 months now.
Oct 13 2014
Hello werner,if possible have a look.
Sep 23 2014
Hello, Werner, Kindly have a look at this bug and patch,as and when you are
free. Thanks.
Aug 29 2014
ok sir, i will abide by what you say.
I include both of you as i noticed that you both are active code checkers in
Gcrypt, thats the only reason, anyways thanks for lookup.
Reminder for bug review.
Reminder for bug review.
Reminder for bug review.
Aug 27 2014
File: cipher/pubkey.c
Bug No. : 1
Function: gcry_pk_encrypt
Line of error: 2879
Resource leak occurs as variable "data" with assigned memory is not freed
before going out of scope , which causes memory leak.
Libgcrypt version 1.5.4 code:
rc = sexp_data_to_mpi (s_data, &data, &ctx); if (rc) goto leave;
-> here when the code flow jumps to leave,"data" goes out of scope ,which
despite of being allocated memory is not freed before going out of scope.
Recommended Code:
rc = sexp_data_to_mpi (s_data, &data, &ctx);
if (rc)
{ mpi_free (data); data = NULL; goto leave; }
Here it is ensured that "data" is freed ,preventing any chances of leak
Bug No. : 2
Function: gcry_pk_genkey
Line of error: 3623
Resource leak occurs as variable "string" with assigned memory is not freed
before going out of scope , which causes memory leak.
Libgcrypt version 1.5.4 code:
if (!arg_list) { rc = gpg_err_code_from_syserror (); goto leave; }
-> here when the code flow jumps to leave,"string" goes out of scope ,which
despite of being allocated memory is not freed before going out of scope.
Recommended Code:
if (!arg_list)
{ rc = gpg_err_code_from_syserror (); gcry_free (string) goto leave; }
I am attaching a patch for the above raised bugs.
Aug 26 2014
Aug 21 2014
Yes you may , as it would be quite helpful in further vigilance :)