sacrishi (Sachin Kumar Gupta)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Mar 27 2017, 4:47 PM (120 w, 2 d)
Availability
Available

Recent Activity

Nov 20 2014

sacrishi added a comment to T1705: Resource leak in file "cipher/primegen.c" at line 676 , 1215 and at 1221.

Hello werner, a gentle reminder for this bug, have a look, if possible, it has
been over 3 months now.

Nov 20 2014, 10:25 AM · Bug Report, libgcrypt

Oct 13 2014

sacrishi added a comment to T1705: Resource leak in file "cipher/primegen.c" at line 676 , 1215 and at 1221.

Hello werner,if possible have a look.

Oct 13 2014, 5:40 AM · Bug Report, libgcrypt

Sep 23 2014

sacrishi added a comment to T1705: Resource leak in file "cipher/primegen.c" at line 676 , 1215 and at 1221.

Hello, Werner, Kindly have a look at this bug and patch,as and when you are
free. Thanks.

Sep 23 2014, 6:39 AM · Bug Report, libgcrypt

Aug 29 2014

sacrishi added a comment to T1705: Resource leak in file "cipher/primegen.c" at line 676 , 1215 and at 1221.

ok sir, i will abide by what you say.

Aug 29 2014, 12:13 PM · Bug Report, libgcrypt
sacrishi added a comment to T1706: Resource leak in file "cipher/pubkey.c" in function "gcry_pk_encrypt" at line 2876 and "gcry_pk_genkey" at line 3623.

I include both of you as i noticed that you both are active code checkers in
Gcrypt, thats the only reason, anyways thanks for lookup.

Aug 29 2014, 12:11 PM · Won't Fix, Bug Report, libgcrypt
sacrishi added a comment to T1707: Resource leak in file "cipher/elgamal.c" in function "elg_generate_ext" at line 644.

Reminder for bug review.

Aug 29 2014, 8:57 AM · Bug Report, libgcrypt
sacrishi added a comment to T1705: Resource leak in file "cipher/primegen.c" at line 676 , 1215 and at 1221.

Reminder for bug review.

Aug 29 2014, 8:57 AM · Bug Report, libgcrypt
sacrishi added a comment to T1706: Resource leak in file "cipher/pubkey.c" in function "gcry_pk_encrypt" at line 2876 and "gcry_pk_genkey" at line 3623.

Reminder for bug review.

Aug 29 2014, 8:56 AM · Won't Fix, Bug Report, libgcrypt

Aug 27 2014

sacrishi updated subscribers of T1707: Resource leak in file "cipher/elgamal.c" in function "elg_generate_ext" at line 644.
Aug 27 2014, 11:52 AM · Bug Report, libgcrypt
sacrishi added projects to T1707: Resource leak in file "cipher/elgamal.c" in function "elg_generate_ext" at line 644: libgcrypt, Bug Report.
Aug 27 2014, 11:52 AM · Bug Report, libgcrypt
sacrishi set Version to 1.5.4 on T1707: Resource leak in file "cipher/elgamal.c" in function "elg_generate_ext" at line 644.
Aug 27 2014, 11:52 AM · Bug Report, libgcrypt
sacrishi added a comment to T1707: Resource leak in file "cipher/elgamal.c" in function "elg_generate_ext" at line 644.

D245: 481_elgmal.patch

Aug 27 2014, 11:52 AM · Bug Report, libgcrypt
sacrishi renamed T1706: Resource leak in file "cipher/pubkey.c" in function "gcry_pk_encrypt" at line 2876 and "gcry_pk_genkey" at line 3623 from Resource leak in file "cipher/pubkey.c" in function "gcry_pk_genkey" at line 3623 to Resource leak in file "cipher/pubkey.c" in function "gcry_pk_encrypt" at line 2876 and "gcry_pk_genkey" at line 3623.
Aug 27 2014, 10:53 AM · Won't Fix, Bug Report, libgcrypt
sacrishi added a comment to T1706: Resource leak in file "cipher/pubkey.c" in function "gcry_pk_encrypt" at line 2876 and "gcry_pk_genkey" at line 3623.

D243: 480_pubkey.patch

Aug 27 2014, 10:53 AM · Won't Fix, Bug Report, libgcrypt
sacrishi added a comment to T1706: Resource leak in file "cipher/pubkey.c" in function "gcry_pk_encrypt" at line 2876 and "gcry_pk_genkey" at line 3623.

File: cipher/pubkey.c

Bug No. : 1


Function: gcry_pk_encrypt
Line of error: 2879

Resource leak occurs as variable "data" with assigned memory is not freed
before going out of scope , which causes memory leak.

Libgcrypt version 1.5.4 code:

  rc = sexp_data_to_mpi (s_data, &data, &ctx);
  if (rc)
    goto leave;

-> here when the code flow jumps to leave,"data" goes out of scope ,which
despite of being allocated memory is not freed before going out of scope.

Recommended Code:

rc = sexp_data_to_mpi (s_data, &data, &ctx);
if (rc)

    {
      mpi_free (data);
      data = NULL;
      goto leave;
    }

Here it is ensured that "data" is freed ,preventing any chances of leak

Bug No. : 2


Function: gcry_pk_genkey
Line of error: 3623

Resource leak occurs as variable "string" with assigned memory is not freed
before going out of scope , which causes memory leak.

Libgcrypt version 1.5.4 code:

   if (!arg_list)
        {
          rc = gpg_err_code_from_syserror ();
          goto leave;
        }

-> here when the code flow jumps to leave,"string" goes out of scope ,which
despite of being allocated memory is not freed before going out of scope.

Recommended Code:

if (!arg_list)

{
  rc = gpg_err_code_from_syserror ();
  gcry_free (string)
  goto leave;
}

I am attaching a patch for the above raised bugs.

Aug 27 2014, 10:53 AM · Won't Fix, Bug Report, libgcrypt
sacrishi added a comment to T1706: Resource leak in file "cipher/pubkey.c" in function "gcry_pk_encrypt" at line 2876 and "gcry_pk_genkey" at line 3623.

D244: 479_pubkey.patch

Aug 27 2014, 6:37 AM · Won't Fix, Bug Report, libgcrypt
sacrishi added projects to T1706: Resource leak in file "cipher/pubkey.c" in function "gcry_pk_encrypt" at line 2876 and "gcry_pk_genkey" at line 3623: libgcrypt, Bug Report.
Aug 27 2014, 6:37 AM · Won't Fix, Bug Report, libgcrypt
sacrishi updated subscribers of T1706: Resource leak in file "cipher/pubkey.c" in function "gcry_pk_encrypt" at line 2876 and "gcry_pk_genkey" at line 3623.
Aug 27 2014, 6:37 AM · Won't Fix, Bug Report, libgcrypt
sacrishi set Version to 1.5.4 on T1706: Resource leak in file "cipher/pubkey.c" in function "gcry_pk_encrypt" at line 2876 and "gcry_pk_genkey" at line 3623.
Aug 27 2014, 6:37 AM · Won't Fix, Bug Report, libgcrypt

Aug 26 2014

sacrishi added a comment to T1705: Resource leak in file "cipher/primegen.c" at line 676 , 1215 and at 1221.

D241: 478_primegen.patch

Aug 26 2014, 9:35 AM · Bug Report, libgcrypt
sacrishi updated subscribers of T1705: Resource leak in file "cipher/primegen.c" at line 676 , 1215 and at 1221.
Aug 26 2014, 9:35 AM · Bug Report, libgcrypt
sacrishi assigned T1705: Resource leak in file "cipher/primegen.c" at line 676 , 1215 and at 1221 to werner.
Aug 26 2014, 9:35 AM · Bug Report, libgcrypt
sacrishi added projects to T1705: Resource leak in file "cipher/primegen.c" at line 676 , 1215 and at 1221: libgcrypt, Bug Report.
Aug 26 2014, 9:28 AM · Bug Report, libgcrypt
sacrishi set Version to 1.6.1 on T1705: Resource leak in file "cipher/primegen.c" at line 676 , 1215 and at 1221.
Aug 26 2014, 9:28 AM · Bug Report, libgcrypt
sacrishi added a comment to T1705: Resource leak in file "cipher/primegen.c" at line 676 , 1215 and at 1221.

D242: 477_primegen.patch

Aug 26 2014, 9:28 AM · Bug Report, libgcrypt

Aug 21 2014

sacrishi added a comment to T1698: Dereferencing of a NULL pointer may occur in file "src/sexp.c" in function "vsexp_sscan" inside the for loop on line 1071.

Yes you may , as it would be quite helpful in further vigilance :)

Aug 21 2014, 12:22 PM · Bug Report, libgcrypt
sacrishi updated subscribers of T1697: Wrong if conditional check may lead to dereferencing of a NULL pointer in file cipher/md.c on line 1267.
Aug 21 2014, 10:40 AM · Bug Report, libgcrypt
sacrishi updated subscribers of T1699: A NULL pointer may be dereferenced in file "cipher/dsa.c" inside function "generate " on line 320.
Aug 21 2014, 10:40 AM · Duplicate, Bug Report, libgcrypt
sacrishi updated subscribers of T1698: Dereferencing of a NULL pointer may occur in file "src/sexp.c" in function "vsexp_sscan" inside the for loop on line 1071.
Aug 21 2014, 10:39 AM · Bug Report, libgcrypt
sacrishi updated subscribers of T1700: A NULL pointer may be dereferenced in file "cipher/elgamal.c" inside function "generate_using_x" on line 387.
Aug 21 2014, 10:39 AM · Bug Report, libgcrypt
sacrishi assigned T1697: Wrong if conditional check may lead to dereferencing of a NULL pointer in file cipher/md.c on line 1267 to werner.
Aug 21 2014, 10:37 AM · Bug Report, libgcrypt
sacrishi updated subscribers of T1697: Wrong if conditional check may lead to dereferencing of a NULL pointer in file cipher/md.c on line 1267.
Aug 21 2014, 10:37 AM · Bug Report, libgcrypt
sacrishi updated subscribers of T1700: A NULL pointer may be dereferenced in file "cipher/elgamal.c" inside function "generate_using_x" on line 387.
Aug 21 2014, 8:36 AM · Bug Report, libgcrypt
sacrishi set Version to 1.5.4 on T1700: A NULL pointer may be dereferenced in file "cipher/elgamal.c" inside function "generate_using_x" on line 387.
Aug 21 2014, 8:36 AM · Bug Report, libgcrypt
sacrishi added a comment to T1700: A NULL pointer may be dereferenced in file "cipher/elgamal.c" inside function "generate_using_x" on line 387.

D215: 464_elgamal.patch

Aug 21 2014, 8:36 AM · Bug Report, libgcrypt
sacrishi added projects to T1700: A NULL pointer may be dereferenced in file "cipher/elgamal.c" inside function "generate_using_x" on line 387: libgcrypt, Bug Report.
Aug 21 2014, 8:36 AM · Bug Report, libgcrypt
sacrishi added a comment to T1699: A NULL pointer may be dereferenced in file "cipher/dsa.c" inside function "generate " on line 320.

D214: 463_dsa.patch

Aug 21 2014, 8:23 AM · Duplicate, Bug Report, libgcrypt
sacrishi added projects to T1699: A NULL pointer may be dereferenced in file "cipher/dsa.c" inside function "generate " on line 320: libgcrypt, Bug Report.
Aug 21 2014, 8:23 AM · Duplicate, Bug Report, libgcrypt
sacrishi updated subscribers of T1699: A NULL pointer may be dereferenced in file "cipher/dsa.c" inside function "generate " on line 320.
Aug 21 2014, 8:23 AM · Duplicate, Bug Report, libgcrypt
sacrishi set Version to 1.5.4 on T1699: A NULL pointer may be dereferenced in file "cipher/dsa.c" inside function "generate " on line 320.
Aug 21 2014, 8:23 AM · Duplicate, Bug Report, libgcrypt
sacrishi updated subscribers of T1698: Dereferencing of a NULL pointer may occur in file "src/sexp.c" in function "vsexp_sscan" inside the for loop on line 1071.
Aug 21 2014, 7:44 AM · Bug Report, libgcrypt
sacrishi set Version to 1.5.4 on T1698: Dereferencing of a NULL pointer may occur in file "src/sexp.c" in function "vsexp_sscan" inside the for loop on line 1071.
Aug 21 2014, 7:44 AM · Bug Report, libgcrypt
sacrishi added a comment to T1698: Dereferencing of a NULL pointer may occur in file "src/sexp.c" in function "vsexp_sscan" inside the for loop on line 1071.

D213: 462_sexp.patch

Aug 21 2014, 7:44 AM · Bug Report, libgcrypt
sacrishi added projects to T1698: Dereferencing of a NULL pointer may occur in file "src/sexp.c" in function "vsexp_sscan" inside the for loop on line 1071: libgcrypt, Bug Report.
Aug 21 2014, 7:44 AM · Bug Report, libgcrypt

Aug 20 2014

sacrishi added projects to T1697: Wrong if conditional check may lead to dereferencing of a NULL pointer in file cipher/md.c on line 1267: libgcrypt, Bug Report.
Aug 20 2014, 2:28 PM · Bug Report, libgcrypt
sacrishi added a comment to T1697: Wrong if conditional check may lead to dereferencing of a NULL pointer in file cipher/md.c on line 1267.

D212: 461_md.patch

Aug 20 2014, 2:28 PM · Bug Report, libgcrypt
sacrishi set Version to 1.5.4 on T1697: Wrong if conditional check may lead to dereferencing of a NULL pointer in file cipher/md.c on line 1267.
Aug 20 2014, 2:28 PM · Bug Report, libgcrypt
sacrishi added a comment to T1696: Wrong if conditional check may lead to dereferencing of a NULL pointer in file cipher/md.c on line 1267.

Aug 20 2014, 2:25 PM · Bug Report, Mistaken, libgcrypt
sacrishi set Version to 1.5.4 on T1696: Wrong if conditional check may lead to dereferencing of a NULL pointer in file cipher/md.c on line 1267.
Aug 20 2014, 2:25 PM · Bug Report, Mistaken, libgcrypt
sacrishi added projects to T1696: Wrong if conditional check may lead to dereferencing of a NULL pointer in file cipher/md.c on line 1267: libgcrypt, Bug Report.
Aug 20 2014, 2:25 PM · Bug Report, Mistaken, libgcrypt