Hello werner, a gentle reminder for this bug, have a look, if possible, it has
been over 3 months now.

Hello werner,if possible have a look.

Hello, Werner, Kindly have a look at this bug and patch,as and when you are
free. Thanks.

ok sir, i will abide by what you say.

I include both of you as i noticed that you both are active code checkers in
Gcrypt, thats the only reason, anyways thanks for lookup.

Reminder for bug review.

Reminder for bug review.

Reminder for bug review.

D245: 481_elgmal.patch

D243: 480_pubkey.patch

File: cipher/pubkey.c

Bug No. : 1

Function: gcry_pk_encrypt
Line of error: 2879

Resource leak occurs as variable "data" with assigned memory is not freed
before going out of scope , which causes memory leak.

Libgcrypt version 1.5.4 code:

  rc = sexp_data_to_mpi (s_data, &data, &ctx);
  if (rc)
    goto leave;

-> here when the code flow jumps to leave,"data" goes out of scope ,which
despite of being allocated memory is not freed before going out of scope.

Recommended Code:

rc = sexp_data_to_mpi (s_data, &data, &ctx);
if (rc)

    {
      mpi_free (data);
      data = NULL;
      goto leave;
    }

Here it is ensured that "data" is freed ,preventing any chances of leak

Bug No. : 2

Function: gcry_pk_genkey
Line of error: 3623

Resource leak occurs as variable "string" with assigned memory is not freed
before going out of scope , which causes memory leak.

Libgcrypt version 1.5.4 code:

   if (!arg_list)
        {
          rc = gpg_err_code_from_syserror ();
          goto leave;
        }

-> here when the code flow jumps to leave,"string" goes out of scope ,which
despite of being allocated memory is not freed before going out of scope.

Recommended Code:

if (!arg_list)

{
  rc = gpg_err_code_from_syserror ();
  gcry_free (string)
  goto leave;
}

I am attaching a patch for the above raised bugs.

D244: 479_pubkey.patch

D241: 478_primegen.patch

D242: 477_primegen.patch

Yes you may , as it would be quite helpful in further vigilance :)

D215: 464_elgamal.patch

D214: 463_dsa.patch

D213: 462_sexp.patch

D212: 461_md.patch