Fri, Oct 10
The problem here is that iobuf_readbyte returns -1 on error and on EOF. parse_packet is not able to distinguish that because for histroic reasons we do not return a gpg-error code (GPG_ERR_EOF). To fix this we need to change all callers of parse_packet to not act upon -1 but only on an error code.
Thu, Oct 9
The latter is also the case for deleted softkeys.
Wed, Oct 8
Fixed in 1.56.
Fixed in 1.3.2.
Tue, Oct 7
We recently noticed problem at a customer site with creating the standard rsa3072 keys. It basically stopped working. A likely cause for this seems to be some anti-malware software slowing down file system calls. In the wake of this we looked again at our file locking strategy and found a few things which are not as they should be. For example the release of the lock before a Close call. Trying to fix this unfortunately caused other problems, thus a couple of fixes are needed.
Fri, Oct 3
I updated the branch.
Thu, Oct 2
I implemented that in the old 2.2 branch for easier testing.
Please let us not clutter the code with OS specific things. We could use a gnupg_remove_ext or gnupg_remove_maybe_wait with a wait parameter which maps to a plain gnupg_remove for Unix. The GPGRT_PROCESS_DETACHED, in the asshelp is also the only specific thing which can be move to a file global macro.
I think that modifying gnupg_remove is a bit risky because it's used in many places.
I'd rather introduce new function for Windows; gnupg_w32_delete_file for this particular purpose.
Factoring out wait_when_sharing_violation function from gnupg_rename_file.
Wed, Oct 1
Tested a little late and on Windows 11 with VS-Desktop-3.3.90.16-Beta (a Beta for VSD 3.3.3):
The gnupg_remove should retry if it has a sharing violation. Similar to what we do in gnupg_rename_file. I just figured that we do a remove in the latter function too w/o handling a sharing violation.
Here is a possible fix:
Tue, Sep 30
Wed, Sep 24
Tested with VS-Desktop-3.3.90.12-Beta
I can't find any causes of slowness in keyboxd initialization. I think that there is a situation where it simply takes time on Windows.
Tue, Sep 23
As there has been no more feedback on this for years, I'll close this.
2.2 test can be done with GnuPG-VS-Desktop-3.3.90.12-Beta-Standard.msi from Sep 17
Looks good to me on vsd-3.3.3-beta90.12 @ win10 (temporary filename is now attachment.odt or e.g. attachment (002).odt)
Interesting. That means to replace hundreds of scripts in an average organization :-(.
@ametzler1 Thank you.
Mon, Sep 22
Some data points:
The latest version of the standard (issue 8) has "The -a and -o binary primaries and the '(' and ')' operators have been removed." instead of "obsoleted" https://pubs.opengroup.org/onlinepubs/9799919799/utilities/test.html
Current logs for a forever hang:
still reproducible on gpg4win-5.0.0-beta369 @ win10
test -a is not a POSIX construct, I intentionally avoided it.
Fri, Sep 19
Thanks for fixing this.
@ametzler1 Thank you for your report.
I modified a bit (not using && between two test but using -a for a single test command), and pushed the change:
rP121494245f49: build: Allow build with fltk 1.4.
Thu, Sep 18
Since GnuPG 2.5.3 there is no predefined keyserver anymore: https://dev.gnupg.org/T7442