hwf-x86: remove unused HWF_INTEL_FAST_VPGATHER
Concern Raised2bbbaca18240
Actions

Description

hwf-x86: remove unused HWF_INTEL_FAST_VPGATHER

* cipher/twofish-avx2-amd64.S (RNOT): Update comment on usage of this register
macro.
* doc/gcrypt.texi: Remove 'intel-fast-vpgather'.
* src/g10lib.h (HWF_INTEL_FAST_VPGATHER): Remove.
(HWF_INTEL_RDTSC, HWF_INTEL_SHAEXT, HWF_INTEL_VAES_VPCLMUL, HWF_INTEL_AVX512)
(HWF_INTEL_GFNI): Shift bit position to close the gap left by FAST_VPGATHER
removal.
* src/hwf-x86.c (detect_x86_gnuc): Remove HWF_INTEL_FAST_VPGATHER detection.
* src/hwfeatures.c (hwflist): Remove 'intel-fast-vpgather'.

Signed-off-by: Jussi Kivilinna <jussi.kivilinna@iki.fi>

Details

Auditors

• werner

Provenance

jukivili

Authored on Wed, Sep 17, 7:34 PM

Parents

rC09d411d60bfc: Prepare version number for 1.12.0

Branches

Unknown

Tags

Unknown

Event Timeline

jukivili committed rC2bbbaca18240: hwf-x86: remove unused HWF_INTEL_FAST_VPGATHER (authored by jukivili).Wed, Sep 24, 7:33 AM

• werner raised a concern with this commit.Wed, Sep 24, 9:20 AM

• werner added a subscriber: • werner.

• werner added inline comments.

/src/hwfeatures.c
61	The removal of the "intel-fast-vpgather" is an API break becuase it isused by gcry_disable_hw_feature which would return GPG_ERR_INV_NAMEafter this change. I suggest to use a dummy entry like { 0, "intel-fast-vpgather" }, as a NOP.