Home GnuPG

rijndael-ssse3: fix counter operand from read-only to read/write
34135cd4128bUnpublished

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

rijndael-ssse3: fix counter operand from read-only to read/write

* cipher/rijndael-ssse3-amd64.c (_gcry_aes_ssse3_ctr_enc): Change
'ctrlow' operand from read-only to read-write.

With read-only operand, compiler is allowed to pass temporary
register to assembly block and throw away any calculation that
have been done on that register. On the other hand, compiler is
also allowed to keep operand value permanently in one register
as value is treated as read-only, and effectly operates as
expected. Selection between these two depends on compiler
version and used flags.

(cherry picked from commit aada604594fd42224d366d3cb98f67fd3b989cd6)

  • Signed-off-by: Jussi Kivilinna <jussi.kivilinna@iki.fi>

Details

Provenance
jukiviliAuthored on Jan 4 2017, 11:02 AM
wernerCommitted on Jan 18 2017, 11:32 AM
Parents
rCe4c0159974b0: random: Call getrandom before select and emitting a progress callback.
Branches
Unknown
Tags
Unknown

Event Timeline

Werner Koch <wk@gnupg.org> committed rC34135cd4128b: rijndael-ssse3: fix counter operand from read-only to read/write (authored by Jussi Kivilinna <jussi.kivilinna@iki.fi>).Jan 18 2017, 11:32 AM