Home GnuPG
Diffusion libgcrypt 3f42f727a069

Make sure the grcy_get_config string is always null-terminated.
Audited3f42f727a069
Actions

Description

Make sure the grcy_get_config string is always null-terminated.

* src/global.c (_gcry_get_config): Append null-terminator to output.

Config string was not being explicitly null-terminated which resulted
garbage output from tests/version with ASAN enabled builds.

  • Signed-off-by: Jussi Kivilinna <jussi.kivilinna@iki.fi>

Details

Auditors
• werner
Provenance
jukiviliAuthored on Jan 31 2021, 3:59 PM
• wernerCommitted on Feb 4 2021, 12:49 PM
Parents
rC370e44127287: Add handling for -Og with O-flag munging
Branches
Unknown
Tags
Unknown

Event Timeline

• werner committed rC3f42f727a069: Make sure the grcy_get_config string is always null-terminated. (authored by jukivili).Feb 4 2021, 12:49 PM
jukivili added a subscriber: • werner.Feb 12 2021, 4:16 PM
jukivili added inline comments.
/src/global.c
423

Hm.. Actually this needs to closed with if (!what) {...}.

Otherwise tests/version will print: version: gcry_get_config("no-such-item") returned something.

@werner

• werner added inline comments.Feb 14 2021, 6:48 PM
/src/global.c
423

Right. I was already wondering why you did this in master. I forgot about that test and didn't run a make check.

• werner mentioned this in rCa5799f1618aa: Fix previous commit.Feb 14 2021, 6:58 PM
• werner accepted this commit.Feb 14 2021, 7:00 PM

Fixed with rCa5799f1618aaf1bbb52e7e121275228dd4a3ac8b

All concerns with this commit have now been addressed.Feb 14 2021, 7:00 PM
• werner committed rC3f42f727a069: Make sure the grcy_get_config string is always null-terminated. (authored by jukivili).Feb 4 2021, 12:49 PM

Changes (1)

PathSize
src/

rC3f42f727a069

View Options

src/global.c

Loading...